Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #850: SpringBootGenerator now generates ImageConfiguration with gradle #864

Merged
merged 2 commits into from
Sep 10, 2021

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Aug 25, 2021

Description

Fix #850

  • SpringBootGenerator generates ImageConfiguration when spring boot gradle
    plugin is present in project
  • Enable Generators in AbstractJKubeTask
  • Ported Spring Boot CRD and Spring Boot Camel Complete Quickstarts to gradle
  • Updated spring boot gradle quickstart to use generator customized image configuration

Requires #863 to be merged first.

Signed-off-by: Rohan Kumar rohaan@redhat.com

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #864 (811d57d) into feat/gradle-plugin (63a1193) will increase coverage by 0.03%.
The diff coverage is 85.00%.

Impacted file tree graph

@@                   Coverage Diff                    @@
##             feat/gradle-plugin     #864      +/-   ##
========================================================
+ Coverage                 48.08%   48.12%   +0.03%     
- Complexity                 3509     3514       +5     
========================================================
  Files                       442      442              
  Lines                     20518    20532      +14     
  Branches                   2824     2826       +2     
========================================================
+ Hits                       9867     9880      +13     
- Misses                     9588     9590       +2     
+ Partials                   1063     1062       -1     
Impacted Files Coverage Δ
...kit/common/util/SpringBootConfigurationHelper.java 0.00% <ø> (ø)
...kube/springboot/generator/SpringBootGenerator.java 19.71% <66.66%> (+1.27%) ⬆️
...se/jkube/gradle/plugin/task/AbstractJKubeTask.java 91.04% <81.81%> (-1.94%) ⬇️
...va/org/eclipse/jkube/gradle/plugin/GradleUtil.java 98.07% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63a1193...811d57d. Read the comment docs.

@rohanKanojia rohanKanojia force-pushed the pr/issue850 branch 2 times, most recently from 11c69e8 to ec28221 Compare September 6, 2021 16:17
@manusa manusa linked an issue Sep 8, 2021 that may be closed by this pull request
2 tasks
…ration with gradle

SpringBootGenerator generates ImageConfiguration when spring boot gradle
plugin is present in project

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

89.3% 89.3% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit f52afef into eclipse-jkube:feat/gradle-plugin Sep 10, 2021
@rohanKanojia rohanKanojia deleted the pr/issue850 branch September 10, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KubernetesBuildTask: k8sBuild Generator - SpringBoot
2 participants