-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #850: SpringBootGenerator now generates ImageConfiguration with gradle #864
Merged
manusa
merged 2 commits into
eclipse-jkube:feat/gradle-plugin
from
rohanKanojia:pr/issue850
Sep 10, 2021
Merged
Fix #850: SpringBootGenerator now generates ImageConfiguration with gradle #864
manusa
merged 2 commits into
eclipse-jkube:feat/gradle-plugin
from
rohanKanojia:pr/issue850
Sep 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanKanojia
force-pushed
the
pr/issue850
branch
2 times, most recently
from
August 26, 2021 13:23
5264402
to
78f56b8
Compare
manusa
force-pushed
the
feat/gradle-plugin
branch
from
September 2, 2021 12:50
d729efc
to
9184f23
Compare
rohanKanojia
force-pushed
the
pr/issue850
branch
from
September 2, 2021 14:38
78f56b8
to
de7315d
Compare
Codecov Report
@@ Coverage Diff @@
## feat/gradle-plugin #864 +/- ##
========================================================
+ Coverage 48.08% 48.12% +0.03%
- Complexity 3509 3514 +5
========================================================
Files 442 442
Lines 20518 20532 +14
Branches 2824 2826 +2
========================================================
+ Hits 9867 9880 +13
- Misses 9588 9590 +2
+ Partials 1063 1062 -1
Continue to review full report at Codecov.
|
manusa
force-pushed
the
feat/gradle-plugin
branch
from
September 6, 2021 07:57
1cad01b
to
da4676f
Compare
rohanKanojia
force-pushed
the
pr/issue850
branch
2 times, most recently
from
September 6, 2021 16:17
11c69e8
to
ec28221
Compare
2 tasks
…ration with gradle SpringBootGenerator generates ImageConfiguration when spring boot gradle plugin is present in project Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
force-pushed
the
pr/issue850
branch
from
September 8, 2021 13:37
ec28221
to
811d57d
Compare
Kudos, SonarCloud Quality Gate passed! |
manusa
reviewed
Sep 10, 2021
...-plugin/kubernetes/src/main/java/org/eclipse/jkube/gradle/plugin/task/AbstractJKubeTask.java
Show resolved
Hide resolved
manusa
reviewed
Sep 10, 2021
...it/common/src/main/java/org/eclipse/jkube/kit/common/util/SpringBootConfigurationHelper.java
Show resolved
Hide resolved
manusa
reviewed
Sep 10, 2021
...pring-boot/src/test/java/org/eclipse/jkube/springboot/generator/SpringBootGeneratorTest.java
Show resolved
Hide resolved
manusa
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #850
plugin is present in project
Requires #863 to be merged first.
Signed-off-by: Rohan Kumar rohaan@redhat.com
Type of change
test, version modification, documentation, etc.)
Checklist