Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Submit button not enabled on ComboBox value change #2162

Merged
merged 1 commit into from
Nov 8, 2018
Merged

Fix for Submit button not enabled on ComboBox value change #2162

merged 1 commit into from
Nov 8, 2018

Conversation

ct-ajovanovic
Copy link
Contributor

Brief description of the PR.
Fix for Submit button not enabled on ComboBox value change

Related Issue
This PR fixes/closes #2146 , #2018 , #1965

Description of the solution adopted
If the clicked comboBox value was outside the formPanel, the submitButton was not enabled as the previously created listeners had no effect there.
Added Select listeners on problematic ComboBoxes that trigger onClick() event of the formPanel.
Made changes on the DeviceEditDialog when setting the groupCombo value, because the previous implementation didn't set the value and the originalValue of the field correctly so there were some problems with enabling/disabling the submitButton.

Screenshots
None

Any side note on the changes made
None

Signed-off-by: ct-ajovanovic aleksandra.jovanovic@comtrade.com

Signed-off-by: ct-ajovanovic <aleksandra.jovanovic@comtrade.com>
@LeoNerdoG
Copy link
Contributor

I have verified that this PR successfully resolves issues #2146, #2018 and #1965. Can one of the commiters check the code and merge when all the tests complete?

@codecov
Copy link

codecov bot commented Nov 6, 2018

Codecov Report

Merging #2162 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2162      +/-   ##
=============================================
- Coverage      57.53%   57.53%   -0.01%     
  Complexity      1582     1582              
=============================================
  Files           1062     1062              
  Lines          25935    25935              
  Branches        2294     2294              
=============================================
- Hits           14922    14921       -1     
- Misses         10037    10038       +1     
  Partials         976      976
Impacted Files Coverage Δ Complexity Δ
...a/service/device/registry/internal/DeviceImpl.java 93.2% <0%> (-0.98%) 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17e2b40...96b76a9. Read the comment docs.

@muros-ct muros-ct merged commit bf94c32 into eclipse-kapua:develop Nov 8, 2018
Coduz pushed a commit that referenced this pull request Nov 23, 2018
Signed-off-by: ct-ajovanovic <aleksandra.jovanovic@comtrade.com>
@ct-ajovanovic ct-ajovanovic deleted the fix-issue2146ver2 branch August 20, 2019 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submit Button Not Activated When Reserved User Selected In Connections
3 participants