Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter messages according to metrics in Data view #2674

Merged
merged 1 commit into from
Aug 7, 2019

Conversation

lorthirk
Copy link

@lorthirk lorthirk commented Aug 6, 2019

Currently, messages in Data View are not filtered by metrics: when selecting only some of the checkboxes, while only the selected metrics are correctly added as columns in the result grid, the the messages are not filtered according to them -- meaning that non relevant messages (i.e. messages without the desired metrics) are added to the results anyway. This PR adds the missing metrics filter.

Related Issue
This PR fixes #1687

Description of the solution adopted
A new OrPredicate has been implemented for Storable queries

@lorthirk lorthirk requested a review from Coduz August 6, 2019 14:20
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
@lorthirk lorthirk force-pushed the fix-dataViewFilterMetric branch from 34ed602 to 5347f69 Compare August 6, 2019 14:21
@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #2674 into develop will decrease coverage by 2.69%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             develop   #2674     +/-   ##
===========================================
- Coverage      53.69%     51%   -2.7%     
+ Complexity      2920    2812    -108     
===========================================
  Files           1034    1035      +1     
  Lines          28978   28999     +21     
  Branches        2329    2330      +1     
===========================================
- Hits           15561   14792    -769     
- Misses         12351   13140    +789     
- Partials        1066    1067      +1
Impacted Files Coverage Δ Complexity Δ
...atastore/internal/model/query/OrPredicateImpl.java 0% <0%> (ø) 0 <0> (?)
...rnal/model/query/StorablePredicateFactoryImpl.java 62.5% <0%> (-8.93%) 5 <0> (ø)
...authorization/steps/AuthorizationServiceSteps.java 31.37% <0%> (-56.73%) 56% <0%> (-83%)
.../org/eclipse/kapua/qa/common/cucumber/CucRole.java 17.24% <0%> (-44.83%) 4% <0%> (-9%)
...n/java/org/eclipse/kapua/qa/common/TestDomain.java 20% <0%> (-40%) 0% <0%> (-3%)
...se/kapua/qa/common/cucumber/CucRolePermission.java 35.48% <0%> (-12.91%) 8% <0%> (-1%)
...egistry/event/internal/DeviceEventServiceImpl.java 74.46% <0%> (-12.77%) 12% <0%> (-1%)
...e/kapua/service/user/internal/UserFactoryImpl.java 45.45% <0%> (-9.1%) 3% <0%> (-1%)
...pse/kapua/service/user/steps/UserServiceSteps.java 52.48% <0%> (-7.07%) 47% <0%> (-5%)
...ua/broker/core/listener/DeviceMessageListener.java 46.8% <0%> (-6.39%) 0% <0%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e066c5...5347f69. Read the comment docs.

@Coduz Coduz merged commit 4ae5564 into eclipse-kapua:develop Aug 7, 2019
@lorthirk lorthirk deleted the fix-dataViewFilterMetric branch September 16, 2019 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console - Data view metric filtering not working properly
2 participants