Filter messages according to metrics in Data view #2674
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, messages in Data View are not filtered by metrics: when selecting only some of the checkboxes, while only the selected metrics are correctly added as columns in the result grid, the the messages are not filtered according to them -- meaning that non relevant messages (i.e. messages without the desired metrics) are added to the results anyway. This PR adds the missing metrics filter.
Related Issue
This PR fixes #1687
Description of the solution adopted
A new
OrPredicate
has been implemented for Storable queries