Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test scenarios for data store service #2683

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

ct-anaalbic
Copy link
Contributor

Signed-off-by: ana.albic.comtrade Ana.Albic@comtrade.com

Brief description of the PR.
Added integration test scenarios for data store service.

Related Issue
This PR represents test scenarios for changes which are made on PR #2674

Description of the solution adopted
In this PR, test scenarios are added for newExistPredicate. With this added predicate, message filter only finds messages which are connected with chosen metric. Messages are searched by one metric, two metrics, all metric and in last scenario number of messages are incorrect, and Assertion Error is thrown. Added scenarios in DataStore.feature file are:

1. Find correct number of messages by corresponding metric
2. Finding correct number of messages by corresponding two metrics
3. Finding all messages by selecting all metrics
4. Finding messages with incorrect metric parameters

Screenshots
/

Any side note on the changes made
/

Signed-off-by: ana.albic.comtrade <Ana.Albic@comtrade.com>
@LeoNerdoG
Copy link
Contributor

Hej @lorthirk,
I have checked these tests and they look ok. Ana has followed my scenarios regarding this, so I hope we have covered all cases. The cases are:

  • Find correct number of messages by corresponding metric
  • Finding correct number of messages by corresponding two metrics
  • Finding all messages by selecting all metrics
  • Finding Messages With incorrect Metric parameters

Maybe we have missed something. If you have any additional ideas, please share them with us and we will implement them.
If everything is OK though, please merge into develop as all tests have passed.

@Coduz Coduz requested a review from lorthirk August 27, 2019 12:44
@Coduz Coduz added the Test Test related stuff. It's a dirty job, but someone needs to do that! label Aug 27, 2019
@Coduz Coduz self-requested a review August 27, 2019 12:45
@Coduz Coduz merged commit cf8a834 into eclipse-kapua:develop Aug 27, 2019
@ct-anaalbic ct-anaalbic deleted the dataStoreI9nTests branch October 9, 2019 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test Test related stuff. It's a dirty job, but someone needs to do that!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants