-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix KapuaNamedEntity name validation #2796
Merged
Coduz
merged 10 commits into
eclipse-kapua:develop
from
Coduz:fix-kapuaEntityNameValidation
Dec 18, 2019
Merged
Fix KapuaNamedEntity name validation #2796
Coduz
merged 10 commits into
eclipse-kapua:develop
from
Coduz:fix-kapuaEntityNameValidation
Dec 18, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndle multiple checks Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Coduz
force-pushed
the
fix-kapuaEntityNameValidation
branch
from
December 17, 2019 14:40
806176e
to
e255ded
Compare
lorthirk
approved these changes
Dec 18, 2019
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Codecov Report
@@ Coverage Diff @@
## develop #2796 +/- ##
=============================================
- Coverage 57.46% 57.03% -0.44%
- Complexity 3395 3469 +74
=============================================
Files 1074 1074
Lines 30505 30510 +5
Branches 2436 2436
=============================================
- Hits 17531 17402 -129
- Misses 11804 11946 +142
+ Partials 1170 1162 -8
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the validation on
KapuaNamedEntity
es.The validation of the
name
field for some entities had thw wrong check on the UI and the wrong/none validation on the backend.Related Issue
This PR also fixes #2709 , #2710
Description of the solution adopted
Created a new utility method in
ArgumentValidator
class that validates the value provided supposing it is aKapuaNamedEntity
name.Checks for:
Screenshots
None
Any side note on the changes made
Removed some unused code.
Refactored
ArgumentValidator. lengthRange(...)
with was requiringLong
type for max and min length that made no sense.