Added Tests For Endpoint Service #2808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2808 +/- ##
=============================================
+ Coverage 55.02% 55.08% +0.05%
+ Complexity 2364 2361 -3
=============================================
Files 1021 1021
Lines 21871 21871
Branches 1977 1977
=============================================
+ Hits 12035 12048 +13
+ Misses 8924 8910 -14
- Partials 912 913 +1 |
Coduz
added
the
Test
|
CQ submitted: CQ 21396 |
Coduz
added
the
CQ pending
Coduz
approved these changes
Jan 10, 2020
LeoNerdoG
reviewed
Jan 20, 2020
There was a problem hiding this comment.
Hi @zanpizmoht,
I have reviewed the PR and there are some changes that need to be made.
Please take a look at the comments and fix the selected lines.
LeoNerdoG
reviewed
Jan 20, 2020
There was a problem hiding this comment.
Hi @zanpizmoht,
I have reviewed the PR and there are some changes that need to be made.
Please take a look at the comments and fix the selected lines.
zanpizmoht
force-pushed
the
endpointIntegrationTests
branch
from
1bb6efc to
33ea738
Compare
LeoNerdoG
suggested changes
Jan 31, 2020
There was a problem hiding this comment.
Hey @zanpizmoht,
I have checked this PR again and there are still some comments that need to be addessed. Please review them and fix them accordingly.
zanpizmoht
force-pushed
the
endpointIntegrationTests
branch
from
33ea738 to
1301825
Compare
zanpizmoht
force-pushed
the
endpointIntegrationTests
branch
from
1301825 to
e3882c3
Compare
Coduz
added
CQ approved
Added tests for creating, deleting and editing Endpoints. Signed-off-by: zanpizmoht <zan.pizmoht@comtrade.com>
zanpizmoht
force-pushed
the
endpointIntegrationTests
branch
from
e3882c3 to
5e7fba1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for creating, deleting and editing Endpoints.
Signed-off-by: zanpizmoht zan.pizmoht@comtrade.com
In this PR new test scenarios for Endpoint service are created.
Related Issue
None
Description of the solution adopted
Test scenarios that are added in this PR are checking functionalities regarding Endpoints. All scenarios are added to
EndpointServiceI9n.feature. Scenarios are testing if Endpoints are correctly created, edited or deleted. There are also two scenarios added for testing Endpoint in different accounts.Screenshots
/