Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Tests For Endpoint Service #2881

Merged
merged 1 commit into from
Mar 9, 2020

Conversation

zanpizmoht
Copy link
Contributor

Added tests for creating and editing Endpoints.

Signed-off-by: zanpizmoht zan.pizmoht@comtrade.com

Test scenarios for Endpoint service are added in this PR.

Related Issue
None

Description of the solution adopted
Test scenarios that are added in this PR are checking functionalities regarding Endpoints. All scenarios are added to EndpointServiceI9n.feature. Scenarios are testing if Endpoints are correctly created and edited. There are also two scenarios added for testing Endpoint in different accounts.

Screenshots
/

Any side note on the changes made
@Coduz This PR has to be merged before PR #2808 which is still waiting for CQ. After this is merged, we will just rebase the #2808 and the CQ will not be needed any more, since the total lines count will be less than 1k.

Added tests for creating, deleting and editing Endpoints.

Signed-off-by: zanpizmoht <zan.pizmoht@comtrade.com>
@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #2881 into develop will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2881      +/-   ##
=============================================
- Coverage      55.24%   55.12%   -0.12%     
+ Complexity      2363     2361       -2     
=============================================
  Files           1009     1009              
  Lines          21779    21779              
  Branches        1976     1976              
=============================================
- Hits           12031    12006      -25     
- Misses          8843     8868      +25     
  Partials         905      905
Impacted Files Coverage Δ Complexity Δ
...ore/plugin/authentication/AuthenticationLogic.java 67.5% <0%> (-17.5%) 0% <0%> (ø)
...pse/kapua/broker/core/pool/JmsProducerWrapper.java 50% <0%> (-15%) 0% <0%> (ø)
...nnection/internal/DeviceConnectionCreatorImpl.java 93.1% <0%> (-6.9%) 18% <0%> (-1%)
...ice/job/targets/internal/JobTargetServiceImpl.java 72.72% <0%> (-6.07%) 12% <0%> (-1%)
...stry/connection/internal/DeviceConnectionImpl.java 69.04% <0%> (-4.77%) 18% <0%> (-2%)
...lipse/kapua/kura/simulator/MqttAsyncTransport.java 52.77% <0%> (-2.78%) 0% <0%> (ø)
...e/kapua/broker/core/plugin/metric/LoginMetric.java 84.44% <0%> (-2.23%) 0% <0%> (ø)
.../broker/core/plugin/KapuaSecurityBrokerFilter.java 73.99% <0%> (-1.24%) 0% <0%> (ø)
...obDeviceManagementOperationManagerServiceImpl.java 87.5% <0%> (+2.5%) 16% <0%> (+1%) ⬆️
.../DeviceManagementOperationRegistryServiceImpl.java 72% <0%> (+4%) 14% <0%> (+2%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d408213...a7ea8ee. Read the comment docs.

@Coduz Coduz merged commit 92f88c7 into eclipse-kapua:develop Mar 9, 2020
@Coduz Coduz added the Test Test related stuff. It's a dirty job, but someone needs to do that! label Mar 9, 2020
@zanpizmoht zanpizmoht deleted the endpointIntegrationTestsV1 branch March 26, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test Test related stuff. It's a dirty job, but someone needs to do that!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants