Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tests for Group service #2809

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Added tests for Group service #2809

merged 1 commit into from
Mar 11, 2020

Conversation

zanpizmoht
Copy link
Contributor

@zanpizmoht zanpizmoht commented Jan 8, 2020 •
edited
Loading

Added tests for adding, deleting and editing groups, and adding devices to groups.

Signed-off-by: zanpizmoht zan.pizmoht@comtrade.com

Test scenarios for Groups are added in this PR.

Related Issue
None

Description of the solution adopted
Test scenarios that are added in this PR are checking functionalities regarding Groups. All scenarios are added to GroupService.feature. Scenarios are testing if Groups are correctly created, edited or deleted and if Devices can be added to Groups.

Screenshots
/

@Coduz Coduz self-requested a review January 9, 2020 08:58
@Coduz Coduz added the Test Test related stuff. It's a dirty job, but someone needs to do that! label Jan 9, 2020
@codecov
Copy link

codecov bot commented Jan 9, 2020 •
edited
Loading

Codecov Report

Merging #2809 into develop will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2809      +/-   ##
=============================================
+ Coverage      54.36%   54.52%   +0.16%     
- Complexity      2306     2312       +6     
=============================================
  Files           1021     1021              
  Lines          21871    21871              
  Branches        1977     1977              
=============================================
+ Hits           11890    11925      +35     
+ Misses          9070     9035      -35     
  Partials         911      911
Impacted Files Coverage Δ Complexity Δ
.../DeviceManagementOperationRegistryServiceImpl.java 66.07% <0.00%> (-3.58%) 12.00% <0.00%> (-2.00%)
...nnection/internal/DeviceConnectionServiceImpl.java 66.26% <0.00%> (-2.41%) 14.00% <0.00%> (-1.00%)
...plugin/authentication/UserAuthenticationLogic.java 74.77% <0.00%> (-1.81%) 0.00% <0.00%> (ø%)
...rvice/device/registry/common/DeviceValidation.java 70.00% <0.00%> (+2.50%) 14.00% <0.00%> (+2.00%)
...a/org/eclipse/kapua/transport/mqtt/MqttClient.java 62.19% <0.00%> (+6.09%) 14.00% <0.00%> (ø%)
.../DeviceManagementNotificationMessageProcessor.java 71.42% <0.00%> (+7.14%) 0.00% <0.00%> (ø%)
...ransport/mqtt/pooling/PooledMqttClientFactory.java 71.42% <0.00%> (+9.52%) 7.00% <0.00%> (ø%)
...obDeviceManagementOperationManagerServiceImpl.java 87.01% <0.00%> (+10.38%) 16.00% <0.00%> (+3.00%)
...rtz/persistence/KapuaQuartzConnectionProvider.java 100.00% <0.00%> (+12.50%) 5.00% <0.00%> (+1.00%)
.../transport/mqtt/exception/MqttClientException.java 33.33% <0.00%> (+33.33%) 1.00% <0.00%> (+1.00%)
... and 2 more

@Coduz
Copy link
Contributor

Coduz commented Jan 10, 2020

CQ submitted: CQ 21395

@Coduz Coduz added the CQ pending This PR needs a CQ to be approved from Eclipse before merging. label Jan 10, 2020
LeoNerdoG
LeoNerdoG suggested changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@LeoNerdoG LeoNerdoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zanpizmoht,
I have reviewed the PR and there are some changes that need to be made.

LeoNerdoG
LeoNerdoG suggested changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@LeoNerdoG LeoNerdoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zanpizmoht,
I have reviewed the PR and there are some changes that need to be made.

@zanpizmoht zanpizmoht force-pushed the groupIntegrationTests branch 3 times, most recently from de1c615 to 43ff503 Compare January 30, 2020 07:06
LeoNerdoG
LeoNerdoG reviewed Jan 30, 2020
View reviewed changes
Copy link
Contributor

@LeoNerdoG LeoNerdoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @zanpizmoht, there are only 2 minor things left to change.
Please change them and push to PR.
@Coduz this PR can be labeled as "QA Approved" label.

qa/integration/src/test/resources/features/authorization/GroupService.feature Outdated Show resolved Hide resolved
@zanpizmoht zanpizmoht force-pushed the groupIntegrationTests branch 2 times, most recently from d44e098 to 328865b Compare January 30, 2020 13:48
LeoNerdoG
LeoNerdoG approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@LeoNerdoG LeoNerdoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zanpizmoht,
I have checked all the changes and everything is OK now.
@Coduz, can you please restart the failing tests and merge when CQ passes?

@zanpizmoht zanpizmoht force-pushed the groupIntegrationTests branch from 328865b to c2f8832 Compare February 24, 2020 12:22
@zanpizmoht zanpizmoht mentioned this pull request Mar 9, 2020
Closed
@Coduz
Copy link
Contributor

Coduz commented Mar 10, 2020

CQ Approved! 🎉

@Coduz Coduz added CQ approved The PR has passed CQ approvation and removed CQ pending This PR needs a CQ to be approved from Eclipse before merging. labels Mar 10, 2020
@zanpizmoht zanpizmoht force-pushed the groupIntegrationTests branch from c2f8832 to 3cb83cd Compare March 10, 2020 12:05
Coduz
Coduz requested changes Mar 10, 2020
View reviewed changes
qa/integration/src/test/resources/features/user/UserPermissionI9n.feature Outdated
Comment on lines 1444 to 1450
<<<<<<< HEAD
And I create tag with name "test_tag" without description
And I create the group with name "test_group"
=======
And I create a tag with name "test_tag"
And I create a group with name "test_group"
>>>>>>> Added tests for Group service
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the merge meta data

@zanpizmoht
Added tests for Group service
735c835 
Added tests for adding, deleting and editing groups, and adding devices to groups.

Signed-off-by: zanpizmoht <zan.pizmoht@comtrade.com>
@zanpizmoht zanpizmoht force-pushed the groupIntegrationTests branch from 3cb83cd to 735c835 Compare March 11, 2020 06:29
@zanpizmoht
Copy link
Contributor Author

Hi @Coduz,
I fixed the errors and I saw Travis just passed so this PR is ready to be merged.
Regards, Zan

@Coduz Coduz merged commit c8463ac into eclipse-kapua:develop Mar 11, 2020
@zanpizmoht zanpizmoht deleted the groupIntegrationTests branch March 26, 2020 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeoNerdoG LeoNerdoG LeoNerdoG approved these changes

@Coduz Coduz Coduz approved these changes

Assignees
No one assigned
Labels
CQ approved The PR has passed CQ approvation Test Test related stuff. It's a dirty job, but someone needs to do that!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zanpizmoht @Coduz @LeoNerdoG