Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for Group service #2880

Closed

Conversation

zanpizmoht
Copy link
Contributor

Added tests for adding groups.

Signed-off-by: zanpizmoht zan.pizmoht@comtrade.com

In this PR are added test scenarios for creating groups.

Related Issue
None

Description of the solution adopted
All test scenarios are added to GroupService.feature file and methods for test scenarios are added to AuthorizationServiceSteps.java. I also modified some scenarios in UserRoleServiceI9n.feature and UserRoleServiceI9n.feature file.

Screenshots
/

Any side note on the changes made
@Coduz This PR has to be merged before PR #2809 which is still waiting for CQ. After this is merged, we will just rebase the #2809 and the CQ will not be needed any more, since the total lines count will be less than 1k.

Added tests for adding, deleting and editing groups.

Signed-off-by: zanpizmoht <zan.pizmoht@comtrade.com>
@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #2880 into develop will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2880      +/-   ##
=============================================
+ Coverage      55.24%   55.32%   +0.08%     
- Complexity      2363     2367       +4     
=============================================
  Files           1009     1009              
  Lines          21779    21779              
  Branches        1976     1976              
=============================================
+ Hits           12031    12050      +19     
+ Misses          8843     8826      -17     
+ Partials         905      903       -2
Impacted Files Coverage Δ Complexity Δ
.../engine/jbatch/exception/JobResumingException.java 0% <0%> (-50%) 0% <0%> (-1%)
...ob/engine/jbatch/exception/JobEngineException.java 33.33% <0%> (-33.34%) 1% <0%> (-1%)
...pse/kapua/broker/core/pool/JmsProducerWrapper.java 50% <0%> (-15%) 0% <0%> (ø)
...ice/job/targets/internal/JobTargetServiceImpl.java 72.72% <0%> (-6.07%) 12% <0%> (-1%)
...nnection/internal/DeviceConnectionServiceImpl.java 66.26% <0%> (-2.41%) 14% <0%> (-1%)
...apua/job/engine/jbatch/JobEngineServiceJbatch.java 50% <0%> (-1.86%) 8% <0%> (ø)
.../eclipse/kapua/commons/util/ArgumentValidator.java 92% <0%> (+2%) 0% <0%> (ø) ⬇️
...obDeviceManagementOperationManagerServiceImpl.java 87.5% <0%> (+2.5%) 16% <0%> (+1%) ⬆️
.../DeviceManagementOperationRegistryServiceImpl.java 72% <0%> (+4%) 14% <0%> (+2%) ⬆️
...a/org/eclipse/kapua/transport/mqtt/MqttClient.java 62.82% <0%> (+6.41%) 13% <0%> (ø) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d408213...7e0e864. Read the comment docs.

@Coduz
Copy link
Contributor

Coduz commented Mar 9, 2020

Hi @zanpizmoht ,

this now has some conflicts with develop.
Can you please fix them?

Regards,

Alberto

@Coduz Coduz added the Test Test related stuff. It's a dirty job, but someone needs to do that! label Mar 9, 2020
@zanpizmoht
Copy link
Contributor Author

I am closing this PR because #2809 will be merged as the CQ has been successful.

@zanpizmoht zanpizmoht closed this Mar 10, 2020
@zanpizmoht zanpizmoht deleted the groupIntegrationTestsV1 branch March 26, 2020 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test Test related stuff. It's a dirty job, but someone needs to do that!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants