Added tests for Tag service #2815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coduz
added
the
Test
|
CQ submitted: CQ 21397 |
Coduz
added
the
CQ pending
Codecov Report
@@ Coverage Diff @@
## develop #2815 +/- ##
=============================================
+ Coverage 55.15% 55.19% +0.03%
- Complexity 2368 2373 +5
=============================================
Files 1021 1021
Lines 21871 21871
Branches 1977 1977
=============================================
+ Hits 12063 12071 +8
+ Misses 8897 8890 -7
+ Partials 911 910 -1
|
LeoNerdoG
suggested changes
Jan 21, 2020
There was a problem hiding this comment.
Hi @zanpizmoht,
I have reviewed this PR and there are some changes to be made. Can you please fix the commented stuff? Thanks!
LeoNerdoG
suggested changes
Jan 21, 2020
There was a problem hiding this comment.
Hi @zanpizmoht,
I have reviewed this PR and there are some changes to be made. Can you please fix the commented stuff? Thanks!
zanpizmoht
force-pushed
the
tagIntegrationTests
branch
2 times, most recently
from
8f87145 to
215637c
Compare
LeoNerdoG
approved these changes
Feb 12, 2020
zanpizmoht
force-pushed
the
tagIntegrationTests
branch
from
215637c to
2c28d7e
Compare
Coduz
added
CQ approved
zanpizmoht
force-pushed
the
tagIntegrationTests
branch
2 times, most recently
from
8a3660a to
358c9f4
Compare
Added tests for creating, deleting and editing tags, and assigning tags to devices. Signed-off-by: zanpizmoht <zan.pizmoht@comtrade.com>
zanpizmoht
force-pushed
the
tagIntegrationTests
branch
from
358c9f4 to
dec492f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for creating, deleting and editing tags, and assigning tags to devices.
Signed-off-by: zanpizmoht zan.pizmoht@comtrade.com
Test scenarios for Tags are added in this PR.
Related Issue
None
Description of the solution adopted
Test scenarios that are added in this PR are checking functionalities regarding Tags. All scenarios are added to
TagService.feature. Scenarios are testing if Tags are correctly created, edited and deleted.Screenshots
/