Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquibase Client improvements #2889

Merged
merged 7 commits into from
Mar 13, 2020

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Mar 12, 2020

This PR improves the LiquibaseClient to allow fix to TIMESTAMP columns on MariaDB and MySQL.
See https://liquibase.jira.com/browse/CORE-1958

Related Issue
None

Description of the solution adopted
Added scripts to modify columns to add the subsecond part.
This script are run based on the version of Liquibase module. If after 3.3.3 the script will be executed. If executed prior to that version, the script will modify the columns without the subsecond part again. This fix can be also forced with an additional parameter.

Screenshots
None

Any side note on the changes made
Silenced the Liquibase Client log.
Added a utility class SemanticVersion to simplify handling of the component versions.

@Coduz Coduz added Bug This is a bug or an unexpected behaviour. Fix it! Enhancement This PR/Issue improves an part of Kapua labels Mar 12, 2020
@Coduz Coduz requested a review from lorthirk March 12, 2020 16:10
@Coduz Coduz added the Liquibase Liquibase-related stuff. Better to go easy on those! label Mar 12, 2020
@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #2889 into develop will decrease coverage by 0.06%.
The diff coverage is 58.65%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2889      +/-   ##
=============================================
- Coverage      55.40%   55.34%   -0.07%     
+ Complexity      2378     2374       -4     
=============================================
  Files           1021     1024       +3     
  Lines          21871    21948      +77     
  Branches        1977     1994      +17     
=============================================
+ Hits           12118    12147      +29     
- Misses          8851     8886      +35     
- Partials         902      915      +13     
Impacted Files Coverage Δ Complexity Δ
...se/kapua/broker/core/KapuaDatabaseCheckUpdate.java 38.88% <14.28%> (ø) 0.00 <0.00> (ø)
...rg/eclipse/kapua/commons/util/SemanticVersion.java 39.21% <39.21%> (ø) 0.00 <0.00> (?)
.../kapua/commons/liquibase/KapuaLiquibaseClient.java 87.01% <82.85%> (-6.54%) 0.00 <0.00> (ø)
...liquibase/settings/LiquibaseClientSettingKeys.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...ns/liquibase/settings/LiquibaseClientSettings.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
.../engine/jbatch/exception/JobResumingException.java 0.00% <0.00%> (-50.00%) 0.00% <0.00%> (-1.00%)
...ob/engine/jbatch/exception/JobEngineException.java 33.33% <0.00%> (-33.34%) 1.00% <0.00%> (-1.00%)
...e/kapua/service/user/internal/UserFactoryImpl.java 54.54% <0.00%> (-9.10%) 4.00% <0.00%> (-1.00%)
...a/org/eclipse/kapua/commons/model/id/KapuaEid.java 75.00% <0.00%> (-6.25%) 0.00% <0.00%> (ø%)
.../eclipse/kapua/service/user/internal/UserImpl.java 70.27% <0.00%> (-5.41%) 16.00% <0.00%> (-1.00%)
... and 5 more

Coduz added 7 commits March 13, 2020 09:43
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
…equired

Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
@Coduz Coduz force-pushed the feature-liquibaseImprovements branch from 292a84c to 5d4cf6a Compare March 13, 2020 08:43
@Coduz Coduz merged commit 3f198f3 into eclipse-kapua:develop Mar 13, 2020
@Coduz Coduz deleted the feature-liquibaseImprovements branch March 13, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it! Enhancement This PR/Issue improves an part of Kapua Liquibase Liquibase-related stuff. Better to go easy on those!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants