Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed SemanticVersioning utility class and added jUnit test #2894

Merged
merged 1 commit into from
Mar 17, 2020

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Mar 16, 2020

This PR fixes a bug with SemanticVersioning class.
This bug has been introduced with #2889

Related Issue
None

Description of the solution adopted
Fixed the login and added tests.

Screenshots
None

Any side note on the changes made
None

Signed-off-by: coduz <alberto.codutti@eurotech.com>
@Coduz Coduz added the Bug This is a bug or an unexpected behaviour. Fix it! label Mar 16, 2020
@Coduz Coduz requested a review from lorthirk March 16, 2020 15:39
@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #2894 into develop will increase coverage by 0.13%.
The diff coverage is 57.89%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2894      +/-   ##
=============================================
+ Coverage      55.30%   55.44%   +0.13%     
+ Complexity      2377     2375       -2     
=============================================
  Files           1024     1024              
  Lines          21953    21961       +8     
  Branches        1994     2000       +6     
=============================================
+ Hits           12142    12177      +35     
+ Misses          8899     8868      -31     
- Partials         912      916       +4     
Impacted Files Coverage Δ Complexity Δ
...rg/eclipse/kapua/commons/util/SemanticVersion.java 66.10% <57.89%> (+26.88%) 0.00 <0.00> (ø)
...obDeviceManagementOperationManagerServiceImpl.java 76.62% <0.00%> (-10.39%) 13.00% <0.00%> (-3.00%)
.../DeviceManagementNotificationMessageProcessor.java 64.28% <0.00%> (-7.15%) 0.00% <0.00%> (ø%)
...ice/job/targets/internal/JobTargetServiceImpl.java 72.72% <0.00%> (-6.07%) 12.00% <0.00%> (-1.00%)
...ator/kura/kapua/TranslatorLifeNotifyKuraKapua.java 89.09% <0.00%> (-3.64%) 9.00% <0.00%> (-1.00%)
...apua/job/engine/jbatch/JobEngineServiceJbatch.java 50.00% <0.00%> (-1.86%) 7.00% <0.00%> (-1.00%)
.../kapua/commons/liquibase/KapuaLiquibaseClient.java 88.31% <0.00%> (+1.29%) 0.00% <0.00%> (ø%)
...plugin/authentication/UserAuthenticationLogic.java 76.57% <0.00%> (+1.80%) 0.00% <0.00%> (ø%)
...nnection/internal/DeviceConnectionServiceImpl.java 68.67% <0.00%> (+2.40%) 15.00% <0.00%> (+1.00%)
... and 6 more

@Coduz Coduz merged commit 2508a9c into eclipse-kapua:develop Mar 17, 2020
@Coduz Coduz deleted the fix-semanticVersioning branch March 17, 2020 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant