Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing permissiong check on UserServiceImpl #2938

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

lorthirk
Copy link

@lorthirk lorthirk commented Apr 17, 2020

This PR adds two missing permission check on UserServiceImpl

Related Issue
No relate dissue

Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
@lorthirk lorthirk added the Bug This is a bug or an unexpected behaviour. Fix it! label Apr 17, 2020
@lorthirk lorthirk requested a review from Coduz April 17, 2020 10:56
@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #2938 into develop will increase coverage by 0.06%.
The diff coverage is 50.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2938      +/-   ##
=============================================
+ Coverage      55.57%   55.63%   +0.06%     
  Complexity      2557     2557              
=============================================
  Files           1048     1048              
  Lines          22783    22810      +27     
  Branches        2045     2051       +6     
=============================================
+ Hits           12661    12691      +30     
+ Misses          9175     9169       -6     
- Partials         947      950       +3     
Impacted Files Coverage Δ Complexity Δ
...e/kapua/service/user/internal/UserServiceImpl.java 59.80% <50.00%> (-0.62%) 24.00 <1.00> (+1.00) ⬇️
...efinition/internal/JobStepDefinitionQueryImpl.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...tion/internal/JobStepDefinitionListResultImpl.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
.../engine/jbatch/exception/JobResumingException.java 0.00% <0.00%> (-50.00%) 0.00% <0.00%> (-1.00%)
...ob/engine/jbatch/exception/JobEngineException.java 33.33% <0.00%> (-33.34%) 1.00% <0.00%> (-1.00%)
...inition/internal/JobStepDefinitionFactoryImpl.java 30.00% <0.00%> (-10.00%) 3.00% <0.00%> (-1.00%)
.../DeviceManagementNotificationMessageProcessor.java 64.28% <0.00%> (-7.15%) 0.00% <0.00%> (ø%)
...step/definition/internal/JobStepDefinitionDAO.java 57.89% <0.00%> (-3.22%) 3.00% <0.00%> (ø%)
...pse/kapua/commons/service/internal/ServiceDAO.java 75.00% <0.00%> (-2.25%) 0.00% <0.00%> (ø%)
...apua/job/engine/jbatch/JobEngineServiceJbatch.java 50.00% <0.00%> (-1.86%) 8.00% <0.00%> (-1.00%)
... and 16 more

@Coduz Coduz merged commit aa12747 into eclipse-kapua:develop Apr 20, 2020
@lorthirk lorthirk deleted the fix-userServiceCheckAccess branch April 20, 2020 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants