Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing permissiong check on UserServiceImpl #2938

Merged
merged 1 commit into from
Apr 20, 2020
Merged

Add missing permissiong check on UserServiceImpl #2938

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions .../user/internal/src/main/java/org/eclipse/kapua/service/user/internal/UserServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,15 @@ public User findByName(String name) throws KapuaException {

//
// Do the find
return entityManagerSession.onResult(em -> checkReadAccess(UserDAO.findByName(em, name)));
User user = entityManagerSession.onResult(em -> checkReadAccess(UserDAO.findByName(em, name)));

//
// Check Access
if (user != null) {
authorizationService.checkPermission(permissionFactory.newPermission(UserDomains.USER_DOMAIN, Actions.read, user.getScopeId()));
}

return user;
}

@Override
Expand All @@ -237,7 +245,15 @@ public User findByExternalId(String externalId) throws KapuaException {

//
// Do the find
return entityManagerSession.onResult(em -> checkReadAccess(UserDAO.findByExternalId(em, externalId)));
User user = entityManagerSession.onResult(em -> checkReadAccess(UserDAO.findByExternalId(em, externalId)));

//
// Check Access
if (user != null) {
authorizationService.checkPermission(permissionFactory.newPermission(UserDomains.USER_DOMAIN, Actions.read, user.getScopeId()));
}

return user;
}

@Override
Expand Down