Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature provide compiled version of protobuf payload #3801

Merged
merged 3 commits into from
Jul 19, 2023

Conversation

MDeLuise
Copy link
Contributor

@MDeLuise MDeLuise commented Jun 29, 2023

Brief description of the PR
This PR add the pre-compiled version of the kurapayload.proto.
This allows to:

  • remove the protoc-jar-maven-plugin dependency
  • avoid the compilation of the file every time the project is build
  • (in a future PR) to upgrade the com.google.protobuf:protobuf-java dependency, which currently it's not possible due to the fact that protoc-jar-maven-plugin does not support protobuf 3.21.9.

Related Issue
This PR fixes #3800.

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #3801 (3dda6ef) into develop (ae5dac2) will decrease coverage by 1.74%.
The diff coverage is n/a.

❗ Current head 3dda6ef differs from pull request most recent head 8613eea. Consider uploading reports for the commit 8613eea to get more accurate results

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3801      +/-   ##
=============================================
- Coverage      23.16%   21.42%   -1.74%     
  Complexity        26       26              
=============================================
  Files           1866     1869       +3     
  Lines          35288    39842    +4554     
  Branches        2782     3829    +1047     
=============================================
+ Hits            8175     8538     +363     
- Misses         26801    30893    +4092     
- Partials         312      411      +99     
Impacted Files Coverage Δ
...ua/client/gateway/kura/KuraBinaryPayloadCodec.java 100.00% <ø> (ø)
...lient/gateway/kura/KuraBirthCertificateModule.java 61.53% <ø> (ø)
...se/kapua/client/gateway/kura/internal/Metrics.java 98.55% <ø> (ø)
...ua/client/gateway/kura/proto/KuraPayloadProto.java 16.20% <ø> (ø)
...vice/call/message/kura/proto/KuraPayloadProto.java 0.00% <ø> (ø)
.../org/eclipse/kapua/kura/simulator/app/Request.java 0.00% <ø> (ø)
...a/org/eclipse/kapua/kura/simulator/app/Sender.java 0.00% <ø> (ø)
...pua/kura/simulator/app/data/PeriodicGenerator.java 61.40% <ø> (ø)
...ra/simulator/app/data/SimplePeriodicGenerator.java 0.00% <ø> (ø)
.../eclipse/kapua/kura/simulator/payload/Metrics.java 4.34% <ø> (ø)
... and 1 more

... and 1 file with indirect coverage changes

@Coduz Coduz added the Enhancement This PR/Issue improves an part of Kapua label Jun 30, 2023
@Coduz Coduz removed the Enhancement This PR/Issue improves an part of Kapua label Jun 30, 2023
@Coduz Coduz changed the title Fix provide compiled version of protobuf payload Feature provide compiled version of protobuf payload Jun 30, 2023
@Coduz
Copy link
Contributor

Coduz commented Jun 30, 2023

GitLab issue [1] filed because this PR adds more than 1000 lines

edit: they moved the issue to another board [2]

[1] https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/3340
[2] https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/9232

@Coduz Coduz added the CQ pending This PR needs a CQ to be approved from Eclipse before merging. label Jun 30, 2023
@Coduz
Copy link
Contributor

Coduz commented Jul 19, 2023

CQ approved!
https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/9232#note_71

@Coduz Coduz added CQ approved The PR has passed CQ approvation and removed CQ pending This PR needs a CQ to be approved from Eclipse before merging. labels Jul 19, 2023
@Coduz Coduz merged commit 99c93c9 into eclipse-kapua:develop Jul 19, 2023
@MDeLuise MDeLuise deleted the feature/protobuf-compiled branch July 19, 2023 08:53
Coduz added a commit to Coduz/kapua that referenced this pull request Jul 19, 2023
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Coduz added a commit that referenced this pull request Jul 19, 2023
Agnul97 pushed a commit to Agnul97/kapua that referenced this pull request Jul 20, 2023
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Agnul97 pushed a commit to Agnul97/kapua that referenced this pull request Jul 20, 2023
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CQ approved The PR has passed CQ approvation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide compiled protobuf payload
2 participants