Skip to content

Commit

Permalink
Update dependencies and reports
Browse files Browse the repository at this point in the history 
com.google.guava:guava:32.0.1-jre
  • Loading branch information
@merks
merks committed Jun 30, 2023
1 parent 016447d commit d706d42
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 5 deletions.
2 changes: 2 additions & 0 deletions maven/org.eclipse.oomph.maven.generator/report/m2e/REPORT.md
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# Target Platform: [m2e](https://raw.githubusercontent.com/eclipse-m2e/m2e-core/master/target-platform/target-platform.target)

## Minor Updates
- [com.google.guava](https://repo1.maven.org/maven2/com/google/guava/)
- [guava](https://repo1.maven.org/maven2/com/google/guava/guava/) **[32.0.1-jre](https://repo1.maven.org/maven2/com/google/guava/guava/32.0.1-jre)** < [32.1.0-jre](https://repo1.maven.org/maven2/com/google/guava/guava/32.1.0-jre/)
- [org.jdom](https://repo1.maven.org/maven2/org/jdom/)
- [jdom2](https://repo1.maven.org/maven2/org/jdom/jdom2/) **[2.0.6](https://repo1.maven.org/maven2/org/jdom/jdom2/2.0.6)** < [2.0.6.1](https://repo1.maven.org/maven2/org/jdom/jdom2/2.0.6.1/)

Expand Down
2 changes: 1 addition & 1 deletion maven/org.eclipse.oomph.maven.generator/report/m2e/updated.target
View file
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<version>32.0.1-jre</version>
<version>32.1.0-jre</version>
<type>jar</type>
</dependency>
<dependency>
Expand Down
2 changes: 1 addition & 1 deletion maven/org.eclipse.oomph.maven.generator/report/merged-target/REPORT.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
- [error_prone_annotations](https://repo1.maven.org/maven2/com/google/errorprone/error_prone_annotations/) **[2.20.0](https://repo1.maven.org/maven2/com/google/errorprone/error_prone_annotations/2.20.0)**
- [com.google.guava](https://repo1.maven.org/maven2/com/google/guava/)
- [failureaccess](https://repo1.maven.org/maven2/com/google/guava/failureaccess/) **[1.0.1](https://repo1.maven.org/maven2/com/google/guava/failureaccess/1.0.1)**
- [guava](https://repo1.maven.org/maven2/com/google/guava/guava/) **[32.0.1-jre](https://repo1.maven.org/maven2/com/google/guava/guava/32.0.1-jre)**
- [guava](https://repo1.maven.org/maven2/com/google/guava/guava/) **[32.1.0-jre](https://repo1.maven.org/maven2/com/google/guava/guava/32.1.0-jre)**
- [com.google.inject](https://repo1.maven.org/maven2/com/google/inject/)
- [guice](https://repo1.maven.org/maven2/com/google/inject/guice/) **[7.0.0](https://repo1.maven.org/maven2/com/google/inject/guice/7.0.0)**
- [com.google.inject.extensions](https://repo1.maven.org/maven2/com/google/inject/extensions/)
Expand Down
2 changes: 1 addition & 1 deletion maven/org.eclipse.oomph.maven.generator/report/merged-target/original.target
View file
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ SPDX-License-Identifier: EPL-2.0
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<version>32.0.1-jre</version>
<version>32.1.0-jre</version>
<type>jar</type>
</dependency>
<dependency>
Expand Down
2 changes: 1 addition & 1 deletion maven/org.eclipse.oomph.maven.generator/report/merged-target/updated.target
View file
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ SPDX-License-Identifier: EPL-2.0
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<version>32.0.1-jre</version>
<version>32.1.0-jre</version>
<type>jar</type>
</dependency>
<dependency>
Expand Down
2 changes: 1 addition & 1 deletion maven/tp/Maven.target
View file
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ SPDX-License-Identifier: EPL-2.0
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<version>32.0.1-jre</version>
<version>32.1.0-jre</version>
<type>jar</type>
</dependency>
<dependency>
Expand Down

2 comments on commit d706d42

@jonahgraham
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@merks I don't understand how this update happens? In particular what made the system update to Guava 32.1.0? AFAICT none of the projects use it yet.

In particular I think I understand how the updated.target gets the new version as that is the recommended update (like dependabot). But maven/org.eclipse.oomph.maven.generator/report/merged-target/original.target got the update and I didn't expect that.

This causes the xtext build to fail, but they won't know until their scheduled build runs as they are pulling in 32.0.1 from simrel-orbit: https://github.com/eclipse/xtext/blob/02f11feaf72bf57287fcf8e9f3bbbaa0edbb3253/xtext-latest.target#L56

@merks
Copy link
Contributor Author

@merks merks commented on d706d42 Jul 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I did notify them:

eclipse-xtext/xtext#2707 (comment)

Generally I'm the one driving the updates in the projects...

These updates happen by running this:

image

This collects the of each *.target and checks maven central for other versions of that group/artifactId. It generates a report with the existing versions and available updates to those versions. It generates a new *.target with minor updates (and with major updates for some select coordinates as specified in the launch. For the merged target it does the same thing except it merges all the dependency from all the other sources. The original.target and updated.target are always the same because even the original is a copy of /org.eclipse.oomph.incubator/maven/tp/Maven.target when is generated. I still wanted a report of the content. In all cases, the original is the contents of the target at the time the report runs, but of course this one is special because it actually will be updated.

So yes, updates happen by themselves as they become available.

I'm not sure how updates could happen if one would have to wait for all projects up update their target to specify a specific updated versions. So far I've always just been doing such updates, but then I suppose most folks either don't specify the version in their target or specify the themselves. I think folks should expect there to be updates...

Please sign in to comment.