-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Guice 7 and Guava 32 #2707
Conversation
TODO create mwe milestone and use that |
xtext-r202212.target
Outdated
<unit id="org.objectweb.asm" version="9.5.0"/> | ||
<unit id="io.github.classgraph" version="4.8.149.v20220915-0556"/> | ||
<unit id="org.slf4j.binding.simple" version="0.0.0"/> | ||
<unit id="org.junit" version="4.13.2.v20211018-1956"/> | ||
<unit id="junit-jupiter-api" version="0.0.0"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO undo
e84ff29
to
f20fb85
Compare
@@ -32,16 +32,16 @@ protected void bindToInstance(LinkedBindingBuilder<Object> bind, Object instance | |||
@SuppressWarnings("unchecked") | |||
@Override | |||
protected void bindToClass(LinkedBindingBuilder<Object> bind, Class<?> value) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok this way? still needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine for now
@@ -59,6 +63,11 @@ | |||
|
|||
|
|||
<target name="compiler.init" depends="clean"> | |||
<!-- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to keep this for future use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it at least helped me debugging
...tests/tests/org/eclipse/xtext/common/types/access/xtext/ui/JdtBasedConstructorScopeTest.java
Show resolved
Hide resolved
org.eclipse.xtext.testing | ||
Import-Package: org.apache.log4j;version="1.2.24", | ||
org.eclipse.xtext.testing, | ||
com.google.inject;bundle-version="7.0.0";visibility:=reexport, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are all re-exported from xtext.util.
Why are these changes necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont know. needs to be tested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC, this project was created with copy and paste and its dependencies were never updated.
b8571b9
to
c833098
Compare
running workflows from eclipse leads to
=> also reexport this one? |
but where? |
doing the same reexport in xtext.util seems to work |
7864d68
to
2754642
Compare
</location> | ||
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit"> | ||
<unit id="org.eclipse.xtext.sdk.feature.group" version="0.0.0"/> | ||
<repository location="https://download.eclipse.org/modeling/tmf/xtext/updates/nightly"/> | ||
<repository location="https://ci.eclipse.org/xtext/job/xtext/job/cd_testg32guice7/lastSuccessfulBuild/artifact/build/p2-repository/"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO revert before merge
@szarnekow how to continue here? |
Let's continue the merge + mwe2 release dance |
90db797
to
639b980
Compare
Signed-off-by: Sebastian Zarnekow <sebastian.zarnekow@gmail.com>
reexport failureaccess Signed-off-by: Christian Dietrich <christian.dietrich@itemis.de> package more stuff
639b980
to
4459d5f
Compare
Note that guava 32.1.0.jre is now available in the usual places including of course here: https://repo1.maven.org/maven2/com/google/guava/guava/32.1.0-jre/ |
Does this mean you removed the old ? |
Yes. |
created #2726 |
com.google.guava:guava:32.0.1-jre
No description provided.