GH-5000: Tone down WARN log output for frequent, non-critical events #5006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkleedorfer
changed the title
hmottestad
reviewed
Jun 2, 2024
| @@ -95,7 +95,7 @@ public void closeConnection() { | |||
| } finally { | |||
| try { | |||
| if (con != null && con.isActive()) { | |||
| logger.warn( | |||
There was a problem hiding this comment.
Can you explain why this should be debug instead of warn? Seems like a fairly critical issue with the users code.
There was a problem hiding this comment.
On second thought, I agree with you.
I wanted to reduce the loglevel because I've seen this a lot in my logs without it being of any use, as there were other log messages generated in the same transaction by the problem eventually also leading to this. However, It's just one line, and it is, as you say, pretty serious (the explicit commit or rollback must have failed somehow), so let's leave it in. It might actually be worth digging into the cases in which the message shows up.
There was a problem hiding this comment.
reverted that change.
hmottestad
reviewed
Jun 8, 2024
.../src/main/java/org/eclipse/rdf4j/spring/dao/support/operation/TupleQueryResultConverter.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved: #5000
Briefly describe the changes proposed in this PR:
Reduces loglevel for two very frequent, not-so-serious situations
PR Author Checklist (see the contributor guidelines for more details):
mvn process-resourcesto format from the command line)