-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-5048: updated spring dependency to fix CVEs #5049
GH-5048: updated spring dependency to fix CVEs #5049
Conversation
8bcd5eb
to
875ffd0
Compare
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
875ffd0
to
5a6b5f2
Compare
automated check fails on (unrelated) urlrewrite library |
@@ -371,7 +371,7 @@ | |||
<lucene.version>8.9.0</lucene.version> | |||
<solr.version>8.9.0</solr.version> | |||
<elasticsearch.version>7.15.2</elasticsearch.version> | |||
<spring.version>5.3.30</spring.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spring version should probably match the spring version used in spring-boot. You can update spring-boot to 2.7.18 which uses spring 5.3.31. I think that that version also fixes the CVE.
Spring-boot version should probably be specified in the root pom. At the moment it's defined here:
rdf4j/spring-components/pom.xml
Line 16 in 52b4106
<spring.boot.version>2.7.16</spring.boot.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea
Though probably not the only place, since the rdf4j-server.war also includes spring 5.x jars in the WEB-INF/lib, but not springboot (do we actually used Spring there ?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spring is used in the server. Spring-boot is not used in either the server or workbench. But spring-boot is used in its own sub-module where there are some spring-boot related things and also an example app.
Most people I know only use spring-boot now a days. Some might use a different framework, but I've not heard of anyone that has started a new project with just spring and not spring boot. So it's a good thing to have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know that we have our own jars in the web-inf for spring. That doesn't sound like a good idea.
GitHub issue resolved: #5048
Briefly describe the changes proposed in this PR:
Just a bump in (patch release) version number for Spring Framework
PR Author Checklist (see the contributor guidelines for more details):
mvn process-resources
to format from the command line)