Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-5048: updated spring dependency to fix CVEs #5049

Merged

Conversation

barthanssens
Copy link
Contributor

GitHub issue resolved: #5048

Briefly describe the changes proposed in this PR:

Just a bump in (patch release) version number for Spring Framework


PR Author Checklist (see the contributor guidelines for more details):

  • my pull request is self-contained
  • I've added tests for the changes I made
  • I've applied code formatting (you can use mvn process-resources to format from the command line)
  • I've squashed my commits where necessary
  • every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

@barthanssens barthanssens requested a review from hmottestad June 23, 2024 16:55
@barthanssens barthanssens force-pushed the GH-5048-spring-dependency-update branch 2 times, most recently from 8bcd5eb to 875ffd0 Compare June 23, 2024 17:32
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
@barthanssens barthanssens force-pushed the GH-5048-spring-dependency-update branch from 875ffd0 to 5a6b5f2 Compare June 23, 2024 17:34
@barthanssens
Copy link
Contributor Author

barthanssens commented Jun 23, 2024

automated check fails on (unrelated) urlrewrite library
CQ request pending: https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/15467

@@ -371,7 +371,7 @@
<lucene.version>8.9.0</lucene.version>
<solr.version>8.9.0</solr.version>
<elasticsearch.version>7.15.2</elasticsearch.version>
<spring.version>5.3.30</spring.version>
Copy link
Contributor

@hmottestad hmottestad Jun 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spring version should probably match the spring version used in spring-boot. You can update spring-boot to 2.7.18 which uses spring 5.3.31. I think that that version also fixes the CVE.

Spring-boot version should probably be specified in the root pom. At the moment it's defined here:

<spring.boot.version>2.7.16</spring.boot.version>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea

Though probably not the only place, since the rdf4j-server.war also includes spring 5.x jars in the WEB-INF/lib, but not springboot (do we actually used Spring there ?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spring is used in the server. Spring-boot is not used in either the server or workbench. But spring-boot is used in its own sub-module where there are some spring-boot related things and also an example app.

Most people I know only use spring-boot now a days. Some might use a different framework, but I've not heard of anyone that has started a new project with just spring and not spring boot. So it's a good thing to have.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know that we have our own jars in the web-inf for spring. That doesn't sound like a good idea.

@hmottestad hmottestad merged commit ae61579 into eclipse-rdf4j:main Jul 9, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade spring to 5.3.37
2 participants