Sisu specific PreConstruct/PreDestroy annotations #76
Conversation
"own" annotations for Lifecycle as well (while do support JSR250 if present). This closes eclipse-sisu#58
| @@ -0,0 +1,37 @@ | |||
| /******************************************************************************* | |||
| * Copyright (c) 2010-present Sonatype, Inc. | |||
| * http://www.eclipse.org/legal/epl-v10.html | ||
| * | ||
| * Contributors: | ||
| * Stuart McCulloch (Sonatype, Inc.) - initial API and implementation |
There was a problem hiding this comment.
Shouldn’t that be you @cstamas?
org.eclipse.sisu.inject/src/main/java/org/eclipse/sisu/bean/LifecycleBuilder.java
Outdated
Show resolved
Hide resolved
| * Guice {@link Module} that provides JSR250 lifecycle management by following {@link PostConstruct} and | ||
| * {@link PreDestroy} annotations. The lifecycle can be controlled with the associated {@link BeanManager}. | ||
| * Guice {@link Module} that provides JSR250 lifecycle management by following {@link javax.annotation.PostConstruct} and | ||
| * {@link javax.annotation.PreDestroy} annotations. The lifecycle can be controlled with the associated {@link BeanManager}. |
There was a problem hiding this comment.
Or sisu lifecycle annotations!
|
Re copyright: am really unsure here, @mcculls ? The "old" files DO have (and should keep) these Sonatype headers, but am unsure whhat headers "newly added" files should carry... |
|
Hi @cstamas - for new files you can put your name under both the copyright and contributor lines, following the convention described in https://www.eclipse.org/projects/handbook/#ip-copyright-headers |
|
Personally, but as practical option (as linked doco lists 4th bullet as optional), I'd rather do something like "Sisu Project" or nothing at all for 4th bullet, just standard eclipse header. Wdyt? My thinking is toward simpler formatting/validation, but may be wrong in that respect... |
|
Alternatively we could move to the more generic header and put copyright details in the |
|
Applied header @mcculls proposed |
Just like other annotations like Typed, Priority add "own" annotations for Lifecycle as well (while do support JSR250 if present).
This closes #58