This repository has been archived by the owner on Sep 13, 2024. It is now read-only.
Remove tycho #31
Closed
Remove tycho #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A simple and naive attempt, but fails
kwin
reviewed
Mar 20, 2023
| @@ -0,0 +1,2 @@ | |||
| Bundle-Name: Sisu-Plexus Extender (Incubation) | |||
There was a problem hiding this comment.
@mcculls I don't understand the need of this empty bundle
There was a problem hiding this comment.
It's not completely empty - it contains a META-INF/services file which will get picked up by sisu-inject's extender (the OSGi metadata here should have a fragment entry as in the previous manifest.)
For Maven's purposes you can ignore these extender bundles - they exist only to activate certain behaviour in the main bundles. The reason they are separate is to make deployment easier; so users can choose whether to just have the basic behaviour provided by the main bundles, or a more advanced extension mechanism driven by BundlePlans.
|
The newly generated MANIFEST.MF looks like this: The old manual one was this @mcculls Please cross-check. |
kwin
suggested changes
Mar 20, 2023
| @@ -40,6 +41,8 @@ | |||
| <groupId>javax.annotation</groupId> | |||
| <artifactId>javax.annotation-api</artifactId> | |||
| <version>1.2</version> | |||
| <scope>provided</scope> | |||
There was a problem hiding this comment.
This dependency is not necessary at compile time at all. Isn't the transitive dependency from sisu.inject enough?
There was a problem hiding this comment.
If you look at sisu.inject, it does NOT pulls in guice (any version) transitively, and this is on purpose: let user choose which one (out of supported, guice 3. 4 or 5) to use. As this PR eclipse-sisu/sisu-project#76 is merged (and Typed was already present), IMHO this should be also "opt in" dependency, as it is up to user which one to use from now on: user own annotation or this.
| @@ -48,6 +51,8 @@ | |||
| <groupId>javax.enterprise</groupId> | |||
| <artifactId>cdi-api</artifactId> | |||
| <version>1.2</version> | |||
| <scope>provided</scope> | |||
There was a problem hiding this comment.
This dependency is not necessary at compile time at all. Isn't the transitive dependency from sisu.inject enough?
There was a problem hiding this comment.
Same as for javax.annotation-api
| @@ -32,6 +32,7 @@ | |||
| <artifactId>guice</artifactId> | |||
| <version>4.0</version> | |||
| <scope>provided</scope> | |||
| <optional>true</optional> | |||
There was a problem hiding this comment.
How can this be optional? Guice is essential part of most of the classes, e.g. PlexusRequirements, PlexusConfigurations and others....
There was a problem hiding this comment.
Same as in sisu.inject... long time ago, goal was to make sisu.plexus drop in replacement (so throw out p-c-d and bring in plexus-shim, this project), but IMHO sisu.plexus should become and behave same as sisu.inject: let the user provide needed (and chosen) stuff instead.
Am actually +0 to undo this, I feel those annotations more important to leave out.
| @@ -64,6 +69,20 @@ | |||
| <artifactId>org.eclipse.sisu.inject</artifactId> | |||
| <version>${project.version}</version> | |||
| </dependency> | |||
There was a problem hiding this comment.
a mandatory dependency to javax.inject is necessary as well, as e.g. javax.inject.Provider is used in PlexusRequirements
|
reviewing this today...
|
|
I found a few missing pieces during review so I went and re-applied the steps I took to de-tycho sisu-inject, but modified as appropriate for sisu-plexus. I've merged those to master - the only remaining piece is to align the latest plugin versions and do one last check of the final jars. (I also haven't changed any of the dependency scopes yet) |
|
Closing this PR as not needed anymore. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just removes tycho, in similar way as happened in sisu.inkect.
This PR DOES NOT ADDS OSGI metadata, I'd leave that to one of you two.
One important change: given sisu now has it's own
Typed,PostConstructandPreDestroyannotations, the current two annotation deps (javax.annotation-api and cdi-api) are marked as provided/optional. There is no more need to drag these along, and if someone needs them, can just add them as dependencies (same logic applies as with guice for example).Partially fixes #28