Use the debug adapter from cdt-gdb-vscode/cdt-gdb-adapter #10
Conversation
|
@marechal-p @thegecko The https://github.com/theia-ide/cdt-gdb-vscode I tested using a local npm registry (using verdaccio), but using |
|
Hmm, I'm not sure how I feel about patching adapters specifically for Theia. It introduces overhead to continually maintain a fork (which may fall behind the original without committed support). I'd also like to see all adapters imported in the same way (whether as node modules, downloaded, git modules or otherwise) to promote consistency. |
|
Ok. Since there are no releases of cdt-gdb-vscode, where should we host it? |
simark
force-pushed
the
use-cdt-gdb-adapter
branch
from
c2039e6
to
7364001
Compare
|
Ok, I've built the adapter and hosted it in the https://github.com/theia-ide/cdt-gdb-vscode repo (I find it preferable to have it under the |
simark
force-pushed
the
use-cdt-gdb-adapter
branch
from
7364001
to
b324704
Compare
This patch swaps the debug adapter we use from code-debug to
cdt-gdb-vscode. The adapter was built using
npm install && npm run build && npm pack
and hosted as a release at [1].
The file cpp-debug-configuration-schema.json seems unused, so I've
removed it. The schema for configurations comes from the package.json
of the debug adapter/extension anyway.
[1] https://github.com/theia-ide/cdt-gdb-vscode
Signed-off-by: Simon Marchi <simon.marchi@ericsson.com>
simark
force-pushed
the
use-cdt-gdb-adapter
branch
from
b324704
to
3848962
Compare
That's a very good question. It should be hosted along with the source IMO. So it depends whether we are going to work on a fork or persuade the original authors to host it.
Having it on |
If we eventually use Travis CI in this repo, I think the adapter download during CI will then be subject to the GitHub API rate limit, like we have for ripgrep in the main repo: eclipse-theia/theia#3787 |
|
You may be able to add a GH token to avoid limits. Other CI systems allow you to cache downloads which don't change, too (e.g. CircleCI). |
This patch swaps the debug adapter we use from code-debug to
cdt-gdb-vscode. We depend on a Theia-specific build, because the
cdt-gdb-vscode package needs some tweak to be import-able as a node
package (which is preferable, IMO, to downloading in a (post)install
script).
Signed-off-by: Simon Marchi simon.marchi@ericsson.com