-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[contributor experience] CI often fails for non-committers #3787
Comments
work-around: one can setup Travis CI integration on one's fork of a repo, such as At a point a PR is opened on the main |
@marcdumais-work If we cannot fix the problem, can we make sure that this issue is documented in a place where contributors can find it when their build fails? For example link this issue on the failure page of travis CI? |
@tsmaeder maybe we could add a note in our PR template about this? |
I found that vscode-ripgrep will download ripgrep package to /tmp/vscode-ripgrep-cache-1.2.4/, maybe we can add this directory to cache directories list in .travis.yml. |
This is the PR: #5373 |
(inspired from a gitter interaction)
As per Travis's documentation, PRs from non-committers (i.e. with no write access to repo) do not benefit from encrypted environment variables for their Travis CI jobs. We use such a variable,
GITHUB_TOKEN
, so that Travis CI jobs are authenticated and have a higher API rate limit.If we could somehow get rid of the need to download stuff during post-install of npm dependencies, in particular ripgrep, we would not have a need for the higher GH API rates, for PRs from committers and non, alike. I imagine it's not a "warm and fuzzy" experience to contribute to a project, when CI can't be trusted to approximately work.
Could we build and package ripgrep for the 3 platforms and publish those as npm packages? These could then be cached for Travis, I think? Any other ideas how we could fix this?
The text was updated successfully, but these errors were encountered: