Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 'workbench.action.addRootFolder' vscode command #7350

Merged
merged 1 commit into from
Mar 17, 2020
Merged

Handle 'workbench.action.addRootFolder' vscode command #7350

merged 1 commit into from
Mar 17, 2020

Conversation

tomer-epstein
Copy link
Contributor

Signed-off-by: Tomer Epstein tomer.epstein@sap.com

What it does
This change proposal adds ability to handle workbench.action.addRootFolder command.

How to test
git clone https://github.com/tomer-epstein/vscode-add-Root-Folder
cd vscode-add-Root-Folderr
npm run compile && npm run package
copy vscode-add-Root-Folder-0.0.1.vsix to plugins folder
F1, choose 'Add Root Folder'.

Review checklist

Reminder for reviewers

@tomer-epstein
Copy link
Contributor Author

@vince-fugnitto This PR with correct ECA.

Signed-off-by: Tomer Epstein <tomer.epstein@sap.com>
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomer-epstein the changes worked correctly for me, thank you for your contribution!

@tomer-epstein
Copy link
Contributor Author

@vince-fugnitto does the ripgrep download failure a known issue?
https://travis-ci.com/github/eclipse-theia/theia/jobs/298557964

@vince-fugnitto
Copy link
Member

vince-fugnitto commented Mar 16, 2020

@vince-fugnitto does the ripgrep download failure a known issue?
https://travis-ci.com/github/eclipse-theia/theia/jobs/298557964

Yes it happens when working on forks for non-committers.

@tomer-epstein
Copy link
Contributor Author

tomer-epstein commented Mar 17, 2020

@vince-fugnitto does the ripgrep download failure a known issue?
https://travis-ci.com/github/eclipse-theia/theia/jobs/298557964

Yes it happens when working on forks for non-committers.

@vince-fugnitto do you have the privileges to re-triger the job or can make it pass?

@tomer-epstein
Copy link
Contributor Author

@vince-fugnitto thanks. the build passed.

@vince-fugnitto
Copy link
Member

@vince-fugnitto thanks. the build passed.

Great! I manually restarted it for you.

@vince-fugnitto vince-fugnitto merged commit 9c4e4d9 into eclipse-theia:master Mar 17, 2020
@vince-fugnitto
Copy link
Member

Thank you for your contribution! I look forward to many more in the future.

@tomer-epstein tomer-epstein deleted the workbench.action.addRootFolder branch March 17, 2020 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants