add ripgrep to travis ci cache directories list #5373
Conversation
tom-shan
force-pushed
the
ripgrep-cache
branch
4 times, most recently
from
5c04ee0
to
2a45939
Compare
|
Hopefully, this PR fixes #3787. |
.travis.yml
Outdated
| @@ -66,6 +66,7 @@ cache: | |||
| # end_cache_directories | |||
| - packages/java-debug/download | |||
| - packages/debug-nodejs/download | |||
| - /tmp/vscode-ripgrep-cache-1.2.4 | |||
There was a problem hiding this comment.
only concern that we should keep it sync with rigrep version, maybe we can improve scripts/prepare-travis
tom-shan
force-pushed
the
ripgrep-cache
branch
2 times, most recently
from
ddf2744
to
323aabb
Compare
CI often fails for the github api rate limit when downloading ripgrep package. This workaroud is trying to enable Travis CI cache of the ripgrep package and lower the failure rate. Signed-off-by: tom-shan <swt0008411@163.com>
|
Assuming this works as intended, would there be a way to re-use this strategy when building the docker images in theia-apps? |
|
@marcdumais-work yes, merging, if it helps then we can try with theia-apps |
|
I notice that a couple of recent CI results are still failed. During these builds, there are some weird logs about Travis cache, for example https://travis-ci.org/theia-ide/theia/jobs/547289068#L248 and https://travis-ci.org/theia-ide/theia/jobs/547291207#L248. |
|
@tom-shan thanks for pointing this out. Do we know if caching ripgrep, as done in this PR, has been observed to work for PRs originating from a non-committer's fork? I'll clear the current Travis cache for our project, in case it might help. |
|
Yes, you can refer to https://docs.travis-ci.com/user/caching/#pull-request-builds-and-caches I'm not sure whether clearing cache really help. But it should be pointed out that after the master cache is cleared, you'd better recreate it as soon as possible, or the new PR is going to download the ripgrep from github and may fail the CI. |
+1. Not practically a problem however; the cache was recreated minutes after I cleared it - @akosyakov had a PR being tested that repopulated the cache.
Thanks - that does not prove that the mechanism works as we intended - so far I have not seen a Travis run that succeeds for a non-committer. |
CI often fails for github api rate limit when downloading
ripgrep package. This workaroud is trying to enable
Travis CI cache of ripgrep package.