-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to latest Theia version #9
Conversation
5f3287b
to
ac05514
Compare
I will also open a PR towards the main Theia repo to update the following documentation about using the new way of "loading" the app: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @marcdumais-work, looks good to me and works fine! 👍
Thanks for the quick review @planger ! |
Following this recent Theia commit [1], one now has to use "TheiaAppLoader.load()", to load a Theia application in a theia playwright template. Some code here needs to be updated. Also, use the latest versions (as of now) for @theia/playwright and @playwright/test [1]: "Basic playwright electron support (#12207)" eclipse-theia/theia@487e92b Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
BTW, we have started to make use of this template and the related test infrastructure from |
Update: I noticed there's a workflow in this repository, but CI was disabled because it had not run in a couple of months, I was able to re-enable it in the GitHub UI (Actions tab) and manually launch the tests for this PR. It failed:
update: no extra |
1e5e2a7
to
f2fcd2b
Compare
It turns-out that building Theia works with Python 3.11 (same version used in Theia workflows) but not with version 3.12.2 that was pulled before (when we were requesting 3.x). With the later version, node-gyp would error-out while attempting to build the Theia native dependencies. Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
f2fcd2b
to
d57a16e
Compare
It turns-out that the Theia build issue was apparently caused by a later version of Python being pulled. Now the workflow uses 3.11, like Theia workflows, and Theia builds. |
Oh, thank you very much for re-enabling the CI and tracking down the CI issue! |
Following this recent Theia commit [1], one now has to use "TheiaAppLoader.load()", to load a Theia application in a theia playwright templace. Some code here needs to be updated.
Also, use the latest versions (as of now) for @theia/playwright and @playwright/test
[1]: "Basic playwright electron support (#12207)"
eclipse-theia/theia@487e92b