-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[playwright] Update documentation #13489
Conversation
Since a recent enhancement/refactoring of @theia/playwright, to permit using it in Theia Electron applications, the way to load an application has changed. This commit is an attempt to update the examples that are part of the documentation. I validated the changes in the "theia-playwright-template" repository, and so I have adapted the sample code to that repo's linting rules (using single quotes instead of double). It's possible that other things have changed, that I have not yet encountered, but this should be a good step forward, at least for those just getting started integrating playwright to test their Theia-based app. Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much @marcdumais-work! We totally missed updating the docs when adding the Electron support. Your changes look good to me! 👍
Thanks for the quick review @planger ! |
@marcdumais-work Yes, I'm fine to merge it. Edit: forgot to add link to https://github.com/eclipse-theia/theia-playwright-template |
Would similarly updating the workflow for |
Yes. definitely! That would be great. However, don't feel obligated to do it, I'm happy to put it on our list too. Thank you! |
What it does
Note: this goes along with this
theia-playwright-template
PR:eclipse-theia/theia-playwright-template#9
Since a recent enhancement/refactoring of @theia/playwright [1], to permit using it in Theia Electron applications, the way to load an application has changed. This commit is an attempt to update the examples that are part of the documentation. I validated the changes in the "theia-playwright-template" repository, and so I have adapted the sample code to that repo's linting rules (using single quotes instead of double).
It's possible that other things have changed, that I have not yet encountered, but this should be a good step forward, at least for those just getting started integrating playwright to test their Theia-based app.
[1]: "Basic playwright electron support (#12207)"
487e92b
How to test
This is mostly a documentation change. I guess it could be tested after the PR listed above is merged, reproducing the documentation's examples using the latest "theia-playwright-template" code. But perhaps a visual inspection could be enough.
Follow-ups
Review checklist
Reminder for reviewers