Skip to content

Commit

Permalink
terminal: fix color theming
Browse files Browse the repository at this point in the history
Fixes #7280

This commit fixes the issue where VS Code terminal theming was not
applied correctly. Since the VS Code theming options for terminals
and the `xterm` ITheme differed (lower-case first letter), the terminal themes
were not applied properly.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
  • Loading branch information
vince-fugnitto committed Mar 12, 2020
1 parent 07d0133 commit a1a6deb
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion packages/terminal/src/browser/terminal-theme-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,8 @@ export class TerminalThemeService {
};
// eslint-disable-next-line guard-for-in
for (const id in terminalAnsiColorMap) {
const colorName = id.substring(13);
const colorId = id.substring(13);
const colorName = colorId.charAt(0).toLowerCase() + colorId.slice(1);
// eslint-disable-next-line @typescript-eslint/no-explicit-any
(theme as any)[colorName] = this.colorRegistry.getCurrentColor(id);
}
Expand Down

0 comments on commit a1a6deb

Please sign in to comment.