terminal: fix terminal theming

[vince-fugnitto]

Description

terminal theming from VS Code theming extensions does not work properly.
For example, the vscode-builtin-theme-tomorrow-night-blue theme contributes colors to the terminal:

"terminal.ansiBlack": "#111111",
"terminal.ansiRed": "#ff9da4",
"terminal.ansiGreen": "#d1f1a9",
"terminal.ansiYellow": "#ffeead",
"terminal.ansiBlue": "#bbdaff",
"terminal.ansiMagenta": "#ebbbff",
"terminal.ansiCyan": "#99ffff",
"terminal.ansiWhite": "#cccccc",
"terminal.ansiBrightBlack": "#333333",
"terminal.ansiBrightRed": "#ff7882",
"terminal.ansiBrightGreen": "#b8f171",
"terminal.ansiBrightYellow": "#ffe580",
"terminal.ansiBrightBlue": "#80baff",
"terminal.ansiBrightMagenta": "#d778ff",
"terminal.ansiBrightCyan": "#78ffff",
"terminal.ansiBrightWhite": "#ffffff"

Theia

VS Code

[vince-fugnitto]

It looks like we have logic already to handle the foreground colors but they do not seem to be applied properly:

theia/packages/terminal/src/browser/terminal-theme-service.ts

Line 25 in 42b73d5

export const terminalAnsiColorMap: { [key: string]: { index: number, defaults: ColorDefaults } } = {

[akosyakov]

It should be already supported:

theia/packages/terminal/src/browser/terminal-theme-service.ts

Line 25 in 357b8e9

export const terminalAnsiColorMap: { [key: string]: { index: number, defaults: ColorDefaults } } = {

Maybe some regression.

[vince-fugnitto]

Maybe some regression.

I thought it might have been caused by the xterm update (#7121) but it was not the case.
I verified with the commit c5569a4

[ghost]

One problem that I noticed is that, when we do id.substring(13) here , we get Black instead of black expected by xterm.js. I am doing that conversion in my local to make my hard-coded theme (from color map above) to load up correctly. Does that make sense? But we need to see if that is applicable to loading theme from VS Code plugins and user settings. I don't see any code related to either feature in the code. VS Code takes a slightly different approach to some of these problems: terminaColorRegistry.ts and terminalInstance.ts.

[ghost]

Here is a simple correction that can be applied here to make it load from the theme correctly:

const colorKey = id.substring(13);
const colorName = colorKey.charAt(0).toLowerCase() + colorKey.substring(1);