-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature-request]: Floating editor windows #13163
Comments
As far as I can see, VS Code is also using the same approach of just moving the html to a different window, just like we did it for the secondary window support. I believe CSS support, etc. should just work since it's based on webpack finding the right CSS, which is the same mechanism as in the main window. |
A little experimenting shows that the CSS does not get loaded properly when an editor is moved to a secondary window. The problem seems to be that we're missing a call to A second problem I ran into is that beginning with Thirdly, opening other editors, for example with ctrl-click fails silently. I would guess we need to hook up the open event properly. Other things like hover or content assist seem to work fine, though. Editing and saving seem to work fine, as well. |
Extending our current "external window" support to text editors would entail (IMO)
If all goes well, I think these steps should be doable inside two weeks. Steps 1 and 2 could be done as a first step, in order to allow for smaller PR's. Although what we have now works, I don't think it's architecturally correct with secondary window support knowing about webviews. |
Supporting layouts for extracted widgets (having multiple widgets in the same external window) would not change the current architecture as far as css, webview communications, etc. are concerned. However, we would have to
Once we start using drag and drop, should we support moving widgets between secondary windows and back to the original window? |
Reminder: my branch for this is 13163_investigation |
Should have a look at #13214 while we're at it. Editors are not much use if you can't reopen them. |
Related and still open feature request: #11648 |
Context menus are broken even for our current extractable Windowy: #12722 Problem lies in our implementation of |
There is another problem related to the "references" zone view: the view uses a |
Turns out |
- moves hard-coded support for webviews in secondary windows into the webviews support - introduces patch-package as a way to manage Phosphor patches - fixes the context menu support in secondary windows fixes eclipse-theia#13163, eclipse-theia#12722 contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
On the "bright" side, navigating via the PeekView does not work reliably in VS Code, either. |
Found another issue: resizing the Peek View does not work in the secondary windows. It works in VS Code. |
- moves hard-coded support for webviews in secondary windows into the webviews support - introduces patch-package as a way to manage Phosphor patches - fixes the context menu support in secondary windows fixes eclipse-theia#13163, eclipse-theia#12722 contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Diagnostics don't work when introducing an error in a secondary window with typescript: seems the typescript extensions keeps track of which tabs are shown to the user and only computes diagnostics for open tabs. I suspect the editors in external windows are not part of any tabs and therefore no diagnostics are computed. |
The problem with the PeekView not being resizable is a problem in the VS Code code: in
however, were using version 1.83.1, where the code still was
The problem here is that the listener is added to the main window ( |
The relevant PR in VS Code is microsoft/vscode#195778 |
- moves hard-coded support for webviews in secondary windows into the webviews support - introduces patch-package as a way to manage Phosphor patches - fixes the context menu support in secondary windows fixes eclipse-theia#13163, eclipse-theia#12722 contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
- moves hard-coded support for webviews in secondary windows into the webviews support - introduces patch-package as a way to manage Phosphor patches - fixes the context menu support in secondary windows fixes eclipse-theia#13163, eclipse-theia#12722 contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
- moves hard-coded support for webviews in secondary windows into the webviews support - introduces patch-package as a way to manage Phosphor patches - fixes the context menu support in secondary windows fixes eclipse-theia#13163, eclipse-theia#12722 contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
- moves hard-coded support for webviews in secondary windows into the webviews support - introduces patch-package as a way to manage Phosphor patches - fixes the context menu support in secondary windows fixes #13163, #12722 contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Feature Description:
Something like what VS Code (1.85.0) can do: https://code.visualstudio.com/updates/v1_85#_floating-editor-windows
The text was updated successfully, but these errors were encountered: