Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: secondary window cannot be reopened after closing it #13214

Closed
Tracked by #13192
, #13493
...
vladarama opened this issue Dec 27, 2023 · 6 comments · Fixed by #13509
Closed
Tracked by #13192
, #13493
...

bug: secondary window cannot be reopened after closing it #13214

vladarama opened this issue Dec 27, 2023 · 6 comments · Fixed by #13509
Assignees
@tsmaeder
Labels
bug bugs found in the application secondary-window issues related to multi or secondary window support
Milestone
1.48.0

Comments

@vladarama
Copy link
Contributor

Bug Description:

In the browser application, we cannot reopen the same secondary window after closing it. The only way to reopen the file is to reload the application. Note: this bug is only present on the browser app, the electron app works well.

Demo:
secondary window not reopening

Steps to Reproduce:

  1. Open Theia browser application.
  2. Install the drawio extension.
  3. Create a new test.drawio file and open the file.
  4. Move the view to a secondary window by pressing the button.
  5. Close the secondary window.
  6. Try opening test.drawio, it will not open.

Additional Information

  • Operating System: Windows 10
  • Theia Version: 1.45
@JonasHelming
Copy link
Contributor

@tsmaeder

@tsmaeder
Copy link
Contributor

Note that the window remains open in the "SecondaryWindow" section in the "Open Editors" view. When clicking the close button in the "Open Editors" view, the file can be opened again.

@vladarama
Copy link
Contributor Author

@tsmaeder
Good catch, I didn't spot that.
I still think that the behavior could be improved. Having to close the secondary-window from the Open Editors before being able to reopen the file is not very intuitive for users. Any thoughts ?

@tsmaeder
Copy link
Contributor

tsmaeder commented Dec 27, 2023 •
edited
Loading

@vladarama this is definitely a bug.

@msujew msujew added bug bugs found in the application secondary-window issues related to multi or secondary window support labels Jan 10, 2024
This was referenced Feb 27, 2024
Closed
Open
@JonasHelming
Copy link
Contributor

@tsmaeder Just a reminder of this, it might play a role in your current work on detachable editors!?

@tsmaeder
Copy link
Contributor

Turns out we just never call ApplicationShell.closeWidget() in the browser case. The call got lost in the refactoring to enable secondary windows in electron.

@tsmaeder tsmaeder mentioned this issue Mar 14, 2024
Merged
4 tasks
tsmaeder added a commit to tsmaeder/theia that referenced this issue Mar 20, 2024
@tsmaeder
Make sure we can reopen secondary windows
e679938 
- Refactored to close widget upon browser-case close windows
- Seems 'close' event is no longer fired in browser case. Using 'unload'

Fixes eclipse-theia#13214

Contributred on behalf of STMicroelectronics.

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
@tsmaeder tsmaeder mentioned this issue Mar 20, 2024
Merged
1 task
tsmaeder added a commit that referenced this issue Mar 21, 2024
@tsmaeder
Make sure we can reopen secondary windows (#13509)
c500d0e 
- Refactored to close widget upon browser-case window close
- Seems 'close' event is no longer fired in browser case. Using 'unload'

Fixes #13214

Contributred on behalf of STMicroelectronics.

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
@jfaltermeier jfaltermeier added this to the 1.48.0 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsmaeder tsmaeder

Labels
bug bugs found in the application secondary-window issues related to multi or secondary window support
Projects
None yet
Milestone
1.48.0
Development

Successfully merging a pull request may close this issue.

Make sure we can reopen secondary windows tsmaeder/theia
5 participants
@JonasHelming @msujew @jfaltermeier @tsmaeder @vladarama