Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[output] Output preferences should belong to browser instead of common #4306

Closed
kittaakos opened this issue Feb 11, 2019 · 1 comment · Fixed by #10154
Closed

[output] Output preferences should belong to browser instead of common #4306

kittaakos opened this issue Feb 11, 2019 · 1 comment · Fixed by #10154
Labels
bug bugs found in the application output issues related to the output

Comments

@kittaakos
Copy link
Contributor

kittaakos commented Feb 11, 2019 •
edited
Loading

@theia/output:
screen shot 2019-02-11 at 20 13 09

Vs.

others:
screen shot 2019-02-11 at 20 11 11

Additional refactorings:

  • once we moved the preferences, the output channel manager and the channel must go to the browser folder too.
@kittaakos kittaakos added bug bugs found in the application output issues related to the output labels Feb 11, 2019
@kittaakos kittaakos assigned kittaakos and unassigned kittaakos Feb 11, 2019
@kittaakos
Copy link
Contributor Author

@marcdumais-work, are we going to release 0.3.20 or 0.4.0? If the latter, I am going to break APIs. Thanks!

// cc @svenefftinge

@kittaakos kittaakos removed their assignment May 3, 2019
@kittaakos kittaakos mentioned this issue Jul 28, 2020
Merged
1 task
@kittaakos kittaakos mentioned this issue Sep 16, 2021
Closed
@vince-fugnitto vince-fugnitto mentioned this issue Sep 22, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application output issues related to the output
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

output: fix runtime-import-check errors eclipse-theia/theia
1 participant
@kittaakos