output: fix runtime-import-check errors
#10154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
quality
vince-fugnitto
force-pushed
the
vf/fix-output
branch
from
6aafb90 to
9fb46b2
Compare
msujew
approved these changes
Sep 22, 2021
vince-fugnitto
force-pushed
the
vf/fix-output
branch
2 times, most recently
from
99c6c7d to
07225c0
Compare
The commit fixes `runtime-import-check` errors in `@theia/output`, but properly organizing code that should be browser-specific outside of common. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
vf/fix-output
branch
from
07225c0 to
ccc8e30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #10119
Fixes: #4306
The pull-request updates output to resolve
runtime-import-checkerrors where common was incorrectly importing code from browser which caused downstream issues due to incompatible runtimes (node ends up pulling browser code through common).How to test
Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com