Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[webview] WebviewPanelSerializer are registered but never used #5647

Closed
akosyakov opened this issue Jul 5, 2019 · 1 comment
Closed

[webview] WebviewPanelSerializer are registered but never used #5647

akosyakov opened this issue Jul 5, 2019 · 1 comment
Assignees
@akosyakov
Labels
bug bugs found in the application vscode issues related to VSCode compatibility webviews issues related to webviews

Comments

@akosyakov
Copy link
Member

vscode.window.registerWebviewPanelSerializer is not really implemented
@akosyakov akosyakov added bug bugs found in the application vscode issues related to VSCode compatibility webviews issues related to webviews labels Jul 5, 2019
@akosyakov akosyakov self-assigned this Jul 5, 2019
@akosyakov akosyakov mentioned this issue Jul 5, 2019
Closed
@akosyakov
Copy link
Member Author

It depends on #5648 It is quite involving to refactor. I will leave it and implementation of onWebview activation event out for now.

@akosyakov akosyakov removed their assignment Jul 5, 2019
@akosyakov akosyakov added the help wanted issues meant to be picked up, require help label Jul 5, 2019
@akosyakov akosyakov mentioned this issue Jul 5, 2019
Closed
5 tasks
@akosyakov akosyakov self-assigned this Oct 28, 2019
@akosyakov akosyakov removed the help wanted issues meant to be picked up, require help label Oct 28, 2019
akosyakov added a commit that referenced this issue Oct 29, 2019
@akosyakov
[webview] fix #5647: restore webviews
3f30d36 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Oct 30, 2019
@akosyakov
[webview] fix #5647: restore webviews
64085da 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 1, 2019
@akosyakov
[webview] fix #5647: restore webviews
7b98e75 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 7, 2019
@akosyakov
[webview] fix #5647: restore webviews
a8d3300 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 7, 2019
@akosyakov
[webview] fix #5647: restore webviews
123d5f2 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 8, 2019
@akosyakov
[webview] fix #5647: restore webviews
4a12781 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 11, 2019
@akosyakov
[webview] fix #5647: restore webviews
f2b558b 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 11, 2019
@akosyakov
[webview] fix #5647: restore webviews
b547104 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 11, 2019
@akosyakov
[webview] fix #5647: restore webviews
9281e82 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue Nov 11, 2019
@akosyakov
[webview] fix eclipse-theia#5647: restore webviews
5908bc4 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue Nov 13, 2019
@akosyakov
[webview] fix eclipse-theia#5647: restore webviews
af2efaa 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 13, 2019
@akosyakov
[webview] fix #5647: restore webviews
21d08e1 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 13, 2019
@akosyakov
[webview] fix #5647: restore webviews
73532c2 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 14, 2019
@akosyakov
[webview] fix #5647: restore webviews
4fb4722 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 14, 2019
@akosyakov
[webview] fix #5647: restore webviews
fbbd3f5 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 15, 2019
@akosyakov
[webview] fix #5647: restore webviews
85edc72 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 16, 2019
@akosyakov
[webview] fix #5647: restore webviews
f97a49d 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 16, 2019
@akosyakov
[webview] fix #5647: restore webviews
f631c45 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Nov 18, 2019
@akosyakov
[webview] fix #5647: restore webviews
d8a79f2 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
westbury added a commit to ARMmbed/theia that referenced this issue Jul 27, 2020
@westbury
Increase line length limit for 17f56a2 ([webview] fix eclipse-theia#5647
12d3a95 
: restore webviews)
westbury added a commit to ARMmbed/theia that referenced this issue Jul 27, 2020
@westbury
Increase line length limit for 17f56a2 ([webview] fix eclipse-theia#5647
d7fbdd4 
: restore webviews)
westbury added a commit to ARMmbed/theia that referenced this issue Jul 27, 2020
@westbury
Increase line length limit for 17f56a2 ([webview] fix eclipse-theia#5647
55f800e 
: restore webviews)
westbury added a commit to ARMmbed/theia that referenced this issue Jul 27, 2020
@westbury
Increase line length limit for 17f56a2 ([webview] fix eclipse-theia#5647
8197e2b 
: restore webviews)
westbury added a commit to ARMmbed/theia that referenced this issue Jul 27, 2020
@westbury
Increase line length limit for 17f56a2 ([webview] fix eclipse-theia#5647
4f4cf90 
: restore webviews)
westbury added a commit to ARMmbed/theia that referenced this issue Jul 27, 2020
@westbury
Increase line length limit for 17f56a2 ([webview] fix eclipse-theia#5647
6901d88 
: restore webviews)
westbury added a commit to ARMmbed/theia that referenced this issue Jul 27, 2020
@westbury
Increase line length limit for 17f56a2 ([webview] fix eclipse-theia#5647
10be329 
: restore webviews)
westbury added a commit to ARMmbed/theia that referenced this issue Jul 27, 2020
@westbury
Increase line length limit for 17f56a2 ([webview] fix eclipse-theia#5647
1a15e8e 
: restore webviews)
westbury added a commit to ARMmbed/theia that referenced this issue Jul 27, 2020
@westbury
Increase line length limit for 17f56a2 ([webview] fix eclipse-theia#5647
c81eb20 
: restore webviews)
westbury added a commit to ARMmbed/theia that referenced this issue Jul 27, 2020
@westbury
Increase line length limit for 17f56a2 ([webview] fix eclipse-theia#5647
276ab22 
: restore webviews)
westbury added a commit to ARMmbed/theia that referenced this issue Jul 27, 2020
@westbury
Increase line length limit for 17f56a2 ([webview] fix eclipse-theia#5647
be65ff1 
: restore webviews)
westbury added a commit to ARMmbed/theia that referenced this issue Jul 27, 2020
@westbury
Increase line length limit for 17f56a2 ([webview] fix eclipse-theia#5647
7bc2d54 
: restore webviews)
westbury added a commit to ARMmbed/theia that referenced this issue Jul 27, 2020
@westbury
Increase line length limit for 17f56a2 ([webview] fix eclipse-theia#5647
d36f307 
: restore webviews)
westbury added a commit to ARMmbed/theia that referenced this issue Jul 27, 2020
@westbury
Increase line length limit for 17f56a2 ([webview] fix eclipse-theia#5647
ef7de32 
: restore webviews)
westbury added a commit to ARMmbed/theia that referenced this issue Jul 27, 2020
@westbury
Increase line length limit for 17f56a2 ([webview] fix eclipse-theia#5647
38e0efc 
: restore webviews)
westbury added a commit to ARMmbed/theia that referenced this issue Jul 27, 2020
@westbury
Increase line length limit for 17f56a2 ([webview] fix eclipse-theia#5647
0a3a05f 
: restore webviews)
westbury added a commit to ARMmbed/theia that referenced this issue Jul 27, 2020
@westbury
Increase line length limit for 17f56a2 ([webview] fix eclipse-theia#5647
f8a6e5d 
: restore webviews)
westbury added a commit to ARMmbed/theia that referenced this issue Jul 27, 2020
@westbury
Increase line length limit for 17f56a2 ([webview] fix eclipse-theia#5647
dcbabc7 
: restore webviews)
westbury added a commit to ARMmbed/theia that referenced this issue Jul 27, 2020
@westbury
Increase line length limit for 17f56a2 ([webview] fix eclipse-theia#5647
1131983 
: restore webviews)
westbury added a commit to ARMmbed/theia that referenced this issue Jul 27, 2020
@westbury
Increase line length limit for 17f56a2 ([webview] fix eclipse-theia#5647
b9d9414 
: restore webviews)
westbury added a commit to ARMmbed/theia that referenced this issue Jul 27, 2020
@westbury
Increase line length limit for 17f56a2 ([webview] fix eclipse-theia#5647
7eaf2d1 
: restore webviews)
westbury added a commit to ARMmbed/theia that referenced this issue Jul 27, 2020
@westbury
Increase line length limit for 17f56a2 ([webview] fix eclipse-theia#5647
5bcf8e7 
: restore webviews)
westbury added a commit to ARMmbed/theia that referenced this issue Jul 28, 2020
@westbury
Increase line length limit for 17f56a2 ([webview] fix eclipse-theia#5647
222e770 
: restore webviews)
westbury added a commit to ARMmbed/theia that referenced this issue Jul 28, 2020
@westbury
Increase line length limit for 17f56a2 ([webview] fix eclipse-theia#5647
a4603d2 
: restore webviews)
westbury added a commit to ARMmbed/theia that referenced this issue Jul 28, 2020
@westbury
Increase line length limit for 17f56a2 ([webview] fix eclipse-theia#5647
93e2868 
: restore webviews)
westbury added a commit to ARMmbed/theia that referenced this issue Jul 28, 2020
@westbury
Increase line length limit for 17f56a2 ([webview] fix eclipse-theia#5647
2763066 
: restore webviews)
westbury added a commit to ARMmbed/theia that referenced this issue Jul 30, 2020
@westbury
Increase line length limit for 17f56a2 ([webview] fix eclipse-theia#5647
5007649 
: restore webviews)
westbury added a commit to ARMmbed/theia that referenced this issue Jul 30, 2020
@westbury
Increase line length limit for 17f56a2 ([webview] fix eclipse-theia#5647
f2aa2ca 
: restore webviews)
westbury added a commit to ARMmbed/theia that referenced this issue Jul 30, 2020
@westbury
Increase line length limit for 17f56a2 ([webview] fix eclipse-theia#5647
29fee41 
: restore webviews)
westbury added a commit to ARMmbed/theia that referenced this issue Jul 30, 2020
@westbury
Increase line length limit for 17f56a2 ([webview] fix eclipse-theia#5647
5a54be0 
: restore webviews)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
bug bugs found in the application vscode issues related to VSCode compatibility webviews issues related to webviews
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akosyakov