Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support do not disturb mode for notifications #5942

Closed
akosyakov opened this issue Aug 14, 2019 · 6 comments · Fixed by #7195
Closed

support do not disturb mode for notifications #5942

akosyakov opened this issue Aug 14, 2019 · 6 comments · Fixed by #7195
Labels
notifications issues related to notifications proposal feature proposals (potential future features)

Comments

@akosyakov
Copy link
Member

It is a follow-up of #5830.

As a user, i want to suppress pop up of all notifications. Instead counter should be updated in the status bar as a reminder that there are some messages. Counter should not blink or something to avoid distracting as well.

In VS Code it is not possible, so it is a proposal to implement in Theia.

cc @AlexTugarev

@akosyakov akosyakov added notifications issues related to notifications proposal feature proposals (potential future features) labels Aug 14, 2019
@AlexTugarev
Copy link
Contributor

I think notifications could be even filtered by severity when it comes to show a toast, e.g. I'd still want to see errors.

@vince-fugnitto
Copy link
Member

Would a preference be sufficient?
Something like being able to:

  • hide all notifications - unless the user explicitly clicks the bell
  • hide all infos
  • hide all warnings
  • never hide

@garethwhittaker
Copy link
Contributor

I'd be interested in picking this task up.
I assume a new preference will be a suitable way to specify which notification types to mute.

@vince-fugnitto
Copy link
Member

vince-fugnitto commented Feb 20, 2020

I'd be interested in picking this task up.

@garethwhittaker sure!

I assume a new preference will be a suitable way to specify which notification types to mute.

I think we can aim to have a single preference (ex: workbench.silentNotifications) which would affect all types of notifications. I could not find a preference in VS Code however.

It might also be interesting for at some point to have an enhancement in the form of a new command which toggles the silentNotifications preference (allows users to turn on/off the setting at will).

vince-fugnitto pushed a commit that referenced this issue Mar 6, 2020
Resolves #5942

Signed-off-by: Gareth Whittaker <garethwhittaker@hotmail.com>
JesterOrNot pushed a commit to JesterOrNot/theia that referenced this issue Mar 12, 2020
Resolves eclipse-theia#5942

Signed-off-by: Gareth Whittaker <garethwhittaker@hotmail.com>
@AmeyaLokre
Copy link

@vince-fugnitto is there plan to support suppressing notifications based on levels as mentioned in your initial comment #5942 (comment) ?

hide all notifications - unless the user explicitly clicks the bell
hide all infos
hide all warnings
never hide

@vince-fugnitto
Copy link
Member

Is there plan to support suppressing notifications based on levels as mentioned in your initial comment

@AmeyaLokre not that I am aware of, and I did not find a similar notification present in vscode. You can always add such a preference in your own application based on Theia if you require the use-case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notifications issues related to notifications proposal feature proposals (potential future features)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants