Notification Center and Progress Service

[AlexTugarev]

What this does

• adds notification center to show user messages in the bottom right corner
• three most recent notifications are shown as "toasts"
• there is a toggle command (and bell icon in the status bar) to open the center
• hide notifications using esc
• makes progress reporting cancellable
• supports links in messages
• collapses looong messages
• moved statusbar progress (aka window location) to core
• adds progress location service and integrates with scm/git

How to test

• using >TXT: commands from https://github.com/AlexTugarev/txt/raw/master/txt-0.0.1.vsix
• using python extension for vscode (which tends to be chatty)

CQs

• https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20492 for react-perfect-scrollbar ✔️

Fixes #1360
Fixes #5635
Fixes #5415

[vince-fugnitto]

@AlexTugarev

It looks much better! Really nice work 👍
I noticed that if no notifications are present, clicking the notifications icon will open the notifications tray. The only problem is that this tray can not be closed :( Toggling the icon or pressing 'x' does not close it.

[vince-fugnitto]

Should we use the close-all icon for the notifications tray (similarly to VSCode) ?

[evidolob]

It works very good!
But I noticed one thing: when notification are closed by time out it removed from notification tray also, so I can loose some important notifications.

How it works now:

How it works in VSCode:

I use VSCode sample to test it.

[AlexTugarev]

You are right @evidolob!
edit: though this is the current behavior on master, it's time to fix it.

✔️

[westbury]

Our UX team here think this is a definite improvement. Apparently users are expecting messages in the lower right corner and during UX testing were missing messages at the top.

There does appear to be a problem with the progress bars. They do not go all the way across. For example this screenshot shows progress over 50% yet the bar is far smaller. Making the same showProgress/reportProgress calls to our original UI shows the correct percentage.

[AlexTugarev]

Apparently users are expecting messages in the lower right corner and during UX testing were missing messages at the top.

@westbury, thanks for sharing!

... a problem with the progress bars.

✔️

[westbury]

I notice that you allow location to be only 'window' (message consumed by StatusBarProgress) or 'notification' (message consumed by NotificationCenterComponent). If you see anything else you switch it to 'notification'. Surely the idea of an extensible platform is that extenders can add their own locations. I would expect to be able to inject NotificationManager into my own UI component to show messages, and to be able to set location to my own custom value. I can see that you may want to be sure that all messages are consumed by at least one UI component, so perhaps there should be a way of registering location ids, or perhaps consumers should have a way of indicating to NotificationManager that they have displayed a message and that it therefore should not go in the notifications component. 'scm' is just one example of a location unknown to core/messages.

[akosyakov]

@westbury We are planning to extend APIs to cover any location. Actually it is already possible in the current state of PR, see ProgressLocationService. After this PR is landed we are going to add progress reporting to the explorer, plugin trees, Monaco to report LSP requests progress and the quick palette. @AlexTugarev please open follow-up issues for each location

[akosyakov]

It would be nice if someone else try it with VS Code extensions contributing progress information.

[akosyakov]

using >TXT: commands from https://github.com/AlexTugarev/txt/raw/master/txt-0.0.1.vsix

@AlexTugarev Where can I see source code of a command to understand what it is supposed to do?

[akosyakov]

Also please update changelog. Is it breaking btw?

[akosyakov]

• I was testing proposed VS Code extension and somehow got in the state that scm progress is running forever.
• I wonder if i collapsed all notification explicitly, should it pop up again? It can be quite annoying if i want to get rid of them. What VS Code does?
• when i open the editor the bell is not in the right most position anymore

[AlexTugarev]

I wonder if i collapsed all notification explicitly, should it pop up again? It can be quite annoying if i want to get rid of them. What VS Code does?

@akosyakov don’t get this. You’re referring to hiding of all notifications, right? That has the same icon as collapse; I’ll replace this to avoid confusion.

If you just hide them and not clear them, you should be able to see them again when you open the center, e.g from status bar.

What is it what you expect? I think this part meets vscode.

[akosyakov]

@AlexTugarev i meant something like do not disturb mode. If it is supported by VS Code now, let's make a new issue, don't need to handle it in this PR. We should start wrapping it up. Let me know when i can have a look at changes.

[akosyakov]

I've tested with the git native and vscode extensions mentioned in How to test section. It behaves well and code looks good. But please sort out context keys before merging.

[akosyakov]

@AlexTugarev i've gave it a try again, it works nicely, please merge.