Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

“Close All” and “Close Others” context menu does not work #6979

Closed
corneliusludmann opened this issue Jan 28, 2020 · 0 comments · Fixed by #6994
Closed

“Close All” and “Close Others” context menu does not work #6979

corneliusludmann opened this issue Jan 28, 2020 · 0 comments · Fixed by #6994
Assignees
@akosyakov
Labels
bug bugs found in the application shell issues related to the core shell

Comments

@corneliusludmann
Copy link
Contributor

Description

Nothing happens when clicking the Close All or the Close Others context menu item:

Peek 2020-01-28 09-00

  • F1 → View: Close other tabs does not work as well
  • F1 → View: Close all tabs does work as expected
  • Other context menu entries do work as expected

Reproduction Steps

  • Start Theia Browser App, I started Theia from Gitpod
  • Open 2 or more files
  • Right click on a text editor tab
  • Click on Close All or Close Others
  • → Nothing happens

OS and Theia version:

  • Theia master (1ca3ec3)
  • Chrome 79.0.3945.130 on GNU/Linux

Diagnostics:
Console logs on click:

root WARN Widget was activated, but did not accept focus after 2000ms: code-editor-opener:file:///workspace/theia/CODE_OF_CONDUCT.md
@akosyakov akosyakov added bug bugs found in the application shell issues related to the core shell labels Jan 28, 2020
@akosyakov akosyakov self-assigned this Jan 28, 2020
akosyakov added a commit that referenced this issue Jan 29, 2020
@akosyakov
fix #6979: ApplicationShell.getAreaFor should treat tab bars specially
dce3b83 
since they are not shell widgets

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov mentioned this issue Jan 29, 2020
Merged
1 task
akosyakov added a commit that referenced this issue Jan 29, 2020
@akosyakov
fix #6979: ApplicationShell.getAreaFor should treat tab bars specially
e38eabb 
since they are not shell widgets

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@akosyakov
fix eclipse-theia#6979: ApplicationShell.getAreaFor should treat tab …
fdc9862 
…bars specially

since they are not shell widgets

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
JesterOrNot pushed a commit to JesterOrNot/theia that referenced this issue Mar 12, 2020
@akosyakov
fix eclipse-theia#6979: ApplicationShell.getAreaFor should treat tab …
39fcb7d 
…bars specially

since they are not shell widgets

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
bug bugs found in the application shell issues related to the core shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix close all and others commands eclipse-theia/theia
2 participants
@akosyakov @corneliusludmann