Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix close all and others commands #6994

Merged
merged 1 commit into from
Jan 29, 2020
Merged

fix close all and others commands #6994

merged 1 commit into from
Jan 29, 2020

Conversation

akosyakov
Copy link
Member

What it does

How to test

  • API test is added
  • Close All and Close others should work as before

Review checklist

Reminder for reviewers

@akosyakov
fix #6979: ApplicationShell.getAreaFor should treat tab bars specially
dce3b83 
since they are not shell widgets

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov added the shell issues related to the core shell label Jan 29, 2020
@akosyakov
Copy link
Member Author

@corneliusludmann could you verify?

AlexTugarev
AlexTugarev approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this issue! Tried both commands, 'works as advertised!

@akosyakov akosyakov merged commit e38eabb into master Jan 29, 2020
@akosyakov akosyakov deleted the akosyakov/close-all-and-close-others-6979 branch January 29, 2020 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexTugarev AlexTugarev AlexTugarev approved these changes

@spoenemann spoenemann Awaiting requested review from spoenemann

@svenefftinge svenefftinge Awaiting requested review from svenefftinge

@vince-fugnitto vince-fugnitto Awaiting requested review from vince-fugnitto

Assignees
No one assigned
Labels
shell issues related to the core shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

“Close All” and “Close Others” context menu does not work
2 participants
@akosyakov @AlexTugarev