Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to latest VS Code URI #7495

Closed
akosyakov opened this issue Apr 3, 2020 · 4 comments · Fixed by #7506
Closed

switch to latest VS Code URI #7495

akosyakov opened this issue Apr 3, 2020 · 4 comments · Fixed by #7506
Assignees
@akosyakov
Labels
monaco issues related to monaco vscode issues related to VSCode compatibility

Comments

@akosyakov
Copy link
Member

See for the motivation: #7462 (comment)
@akosyakov akosyakov added help wanted issues meant to be picked up, require help monaco issues related to monaco vscode issues related to VSCode compatibility labels Apr 3, 2020
@akosyakov akosyakov mentioned this issue Apr 3, 2020
Closed
@akosyakov akosyakov self-assigned this Apr 3, 2020
@akosyakov akosyakov removed the help wanted issues meant to be picked up, require help label Apr 3, 2020
@kittaakos
Copy link
Contributor

See: #6712

@kittaakos
Copy link
Contributor

I already did it once because it was failing in the bundled electron app.

@akosyakov
Copy link
Member Author

I already did it once because it was failing in the bundled electron app.

Where did we get another vscode-uri? It should be declared only in core and never in any other extension?

@kittaakos
Copy link
Contributor

The new version of VS Code URI comes from vscode-json-languageservice.
Here is the issue for electron: https://github.com/kittaakos/test-electron-builder

akosyakov added a commit that referenced this issue Apr 6, 2020
@akosyakov
fix #7495: upgrade to latest vscode-uri to align with URI used by Monaco
8e11932 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov mentioned this issue Apr 6, 2020
Merged
1 task
akosyakov added a commit that referenced this issue Apr 7, 2020
@akosyakov
fix #7495: upgrade to latest vscode-uri to align with URI used by Monaco
1453157 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
monaco issues related to monaco vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

upgrade to latest vscode-uri to align with URI used by Monaco eclipse-theia/theia
2 participants
@kittaakos @akosyakov