-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to latest vscode-uri to align with URI used by Monaco #7506
Conversation
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@kittaakos I did |
I can confirm:
It looks good to me, I have restarted the Windows build, it was falling with an unrelated issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RomanNikitenko leaking emitters should be addressed by #7508 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I played with this change in areas that I am familiar with:
multi root workspace, preferences, tasks, and problem's view. I don't see issues.
eclipse-theia/theia#7506 Change-Id: I8a580fe99eb3bdb17e69e5eeacbd523b712eaa0b Signed-off-by: Florent Benoit <fbenoit@redhat.com>
eclipse-theia/theia#7506 Change-Id: I8a580fe99eb3bdb17e69e5eeacbd523b712eaa0b Signed-off-by: Florent Benoit <fbenoit@redhat.com>
eclipse-theia/theia#7506 Change-Id: I8a580fe99eb3bdb17e69e5eeacbd523b712eaa0b Signed-off-by: Florent Benoit <fbenoit@redhat.com>
What it does
How to test
Review checklist
Reminder for reviewers