Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to latest vscode-uri to align with URI used by Monaco #7506

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Apr 6, 2020

What it does

How to test

  • Use typescript language and node debug feature check that it works.

Review checklist

Reminder for reviewers

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov added monaco issues related to monaco tasks issues related to the task system vscode issues related to VSCode compatibility labels Apr 6, 2020
@akosyakov
Copy link
Member Author

@kittaakos I did yarn why vscode-uri and I don't see duplicate entries.

@kittaakos
Copy link
Contributor

@kittaakos I did yarn why vscode-uri and I don't see duplicate entries.

I can confirm:

gitpod /workspace/theia $ yarn why vscode-uri
yarn why v1.22.4
[1/4] Why do we have the module "vscode-uri"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found "vscode-uri@2.1.1"
info Reasons this module exists
   - "_project_#@theia#core" depends on it
   - Hoisted from "_project_#@theia#core#vscode-uri"
   - Hoisted from "_project_#@theia#json#vscode-json-languageserver#vscode-uri"
   - Hoisted from "_project_#@theia#languages#monaco-languageclient#vscode-uri"
   - Hoisted from "_project_#@theia#json#vscode-json-languageserver#vscode-json-languageservice#vscode-uri"
info Disk size without dependencies: "104KB"
info Disk size with unique dependencies: "104KB"
info Disk size with transitive dependencies: "104KB"
info Number of shared dependencies: 0
Done in 1.59s.

It looks good to me, I have restarted the Windows build, it was falling with an unrelated issue.
I tried the TS functionality, with a few Peek into x, open symbol, diagnostics, and navigation.

Copy link
Contributor

@RomanNikitenko RomanNikitenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was using Theia with the changes about 1 hour.
I didn't notice any regression or hanging

I got a few times a warning at debugging :

debug_error

I don't know if it's actual for master branch

@akosyakov
Copy link
Member Author

@RomanNikitenko leaking emitters should be addressed by #7508

Copy link
Contributor

@elaihau elaihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I played with this change in areas that I am familiar with:
multi root workspace, preferences, tasks, and problem's view. I don't see issues.

@akosyakov akosyakov merged commit 1453157 into master Apr 7, 2020
@akosyakov akosyakov deleted the akosyakov/switch-to-latest-vs-code-7495 branch April 7, 2020 04:16
benoitf added a commit to benoitf/che-theia that referenced this pull request Apr 7, 2020
eclipse-theia/theia#7506

Change-Id: I8a580fe99eb3bdb17e69e5eeacbd523b712eaa0b
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf added a commit to benoitf/che-theia that referenced this pull request Apr 7, 2020
eclipse-theia/theia#7506

Change-Id: I8a580fe99eb3bdb17e69e5eeacbd523b712eaa0b
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf added a commit to eclipse-che/che-theia that referenced this pull request Apr 7, 2020
eclipse-theia/theia#7506

Change-Id: I8a580fe99eb3bdb17e69e5eeacbd523b712eaa0b
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
monaco issues related to monaco tasks issues related to the task system vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

switch to latest VS Code URI
4 participants