Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

about: dialog does not display correctly when re-opened #7144

Merged
merged 1 commit into from
Feb 13, 2020
Merged

about: dialog does not display correctly when re-opened #7144

merged 1 commit into from
Feb 13, 2020

Conversation

Anasshahidd21
Copy link
Contributor

@Anasshahidd21 Anasshahidd21 commented Feb 12, 2020 •
edited by vince-fugnitto
Loading

What it does

Fixes: #7129

The help dialog was not rendering the list of extensions, hence functionality was added to display the list even after it being closed once.

Signed-off-by: Muhammad Anas Shahid muhammad.shahid@ericsson.com

How to test

  1. start the application
  2. in the help menu, select about
  3. the dialog should be successfully displayed (with the list of extensions).
  4. close the dialog using the 'x'
  5. re-perform step 2
  6. the dialog should now be successfully displayed again (with the list of extensions)

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added dialogs issues related to dialogs bug bugs found in the application labels Feb 12, 2020
about: dialog does not display correctly when re-opened
d3b9e42 
Fixes: eclipse-theia#7129
The help dialog was not rendering the list of extensions, hence functionality was added to display the list even after it being closed once.

Signed-off-by: Muhammad Anas Shahid <muhammad.shahid@ericsson.com>
vince-fugnitto
vince-fugnitto approved these changes Feb 12, 2020
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the latest changes and it works correctly 👍
I verified when using the accept and close actions, and re-opening the AboutDialog multiple times.

RomanNikitenko
RomanNikitenko approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@RomanNikitenko RomanNikitenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked both: OK button and close action a few times - it works for me now!
thank you for fix!

@azatsarynnyy azatsarynnyy mentioned this pull request Feb 13, 2020
Closed
20 tasks
@vince-fugnitto vince-fugnitto merged commit 49228c8 into eclipse-theia:master Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akosyakov akosyakov akosyakov left review comments

@RomanNikitenko RomanNikitenko RomanNikitenko approved these changes

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

@lmcbout lmcbout Awaiting requested review from lmcbout

Assignees
No one assigned
Labels
bug bugs found in the application dialogs issues related to dialogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

about: dialog does not display correctly when re-opened
4 participants
@Anasshahidd21 @akosyakov @RomanNikitenko @vince-fugnitto