GH-8654: Fix SelectAll/Copy/Paste Keyboard Shortcuts are not working within DevTools and native input and file dialogs for macOS #8943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
vince-fugnitto
added
bug
|
@zhaomenghuan, thank you for your contribution. I'd have a few remarks, and I was wondering if you're still interested in adjusting the PR a little bit. The approach is good, VS Code does very similar. It turned out copy/pasting works just as is on Windows. I tried with the Theia electron app on Windows. Based on the VS Code codebase, it's most likely not an issue on Linux either. Can you please make your special |
zhaomenghuan
changed the title
… working within DevTools and native input and file dialogs Signed-off-by: 赵梦欢 <zhaomenghuan02@meituan.com>
zhaomenghuan
force-pushed
the
bugfix/electron-menuitem-role
branch
from
9c5778e
to
2e50308
Compare
|
@kittaakos Thank you for your comment and modification suggestion, the modification has been completed, please take the time to review it. |
kittaakos
approved these changes
Feb 18, 2021
|
I assume the |
kittaakos
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixed #8654
Fixed #6217
How to test
System environment：mac OS
You can operate copy (⌘+C), paste (⌘+V) and other operations on DevTools and mini-browser. It is found that the operation cannot be performed normally before the repair, and the operation is normal after the repair.
Review checklist
Reminder for reviewers
Signed-off-by: 赵梦欢 zhaomenghuan02@meituan.com