Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align "ts-node" and "typescript" version #1017

Closed

Conversation

danielpeintner
Copy link
Member

I had to manually tweak package.json in firestore and regenerated package-lock.json.

npm i ts-node@10.9.1 --workspace=./packages/binding-firestore or alike did not work and resulted in "no workspace" found. I guess this is the case since the workspace is deactivated...

fixes #1016

@danielpeintner
Copy link
Member Author

danielpeintner commented Jun 12, 2023

Grr, I am running into this issue microsoft/TypeScript#51567

node_modules/@types/node/globals.d.ts:85:13 - error TS2403: Subsequent variable declarations must have the same type.  Variable 'AbortSignal' must be of type '{ new (): AbortSignal; prototype: AbortSignal; abort(reason?: any): AbortSignal; timeout(milliseconds: number): AbortSignal; }', but here has type '{ new (): AbortSignal; prototype: AbortSignal; }'.

85 declare var AbortSignal: {
               ~~~~~~~~~~~

  node_modules/typescript/lib/lib.dom.d.ts:2071:13
    2071 declare var AbortSignal: {
                     ~~~~~~~~~~~
    'AbortSignal' was also declared here.


Found 1 error.

@danielpeintner
Copy link
Member Author

resolved in #1021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix version inconsistency introduced by PR 1008
1 participant