Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove binding-firestore #1021

Merged
merged 4 commits into from
Jun 13, 2023

Conversation

danielpeintner
Copy link
Member

@danielpeintner danielpeintner commented Jun 12, 2023

fixes #1020

fixes #1016 also

@codecov-commenter
Copy link

Codecov Report

Merging #1021 (f7f508f) into master (ba3f932) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master    #1021   +/-   ##
=======================================
  Coverage   75.79%   75.79%           
=======================================
  Files          72       72           
  Lines       14871    14871           
  Branches     1428     1428           
=======================================
  Hits        11272    11272           
  Misses       3566     3566           
  Partials       33       33           
Impacted Files Coverage Δ
packages/td-tools/src/thing-model-helpers.ts 84.75% <100.00%> (ø)

NOTE: SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <4.5.0
but 4.7.4 seems to work just fine
@danielpeintner danielpeintner changed the title remove firestore chore: remove binding-firestore Jun 12, 2023
Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove firestore binding Fix version inconsistency introduced by PR 1008
3 participants