Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10890] Verify implementation of wait_for_sidecar() checks for respon… #12

Conversation

dennismeister93
Copy link
Contributor

…se status code

Signed-off-by: Dennis Meister dennis.meister@bosch.com

Describe your changes

Verify implementation of wait_for_sidecar() checks for response status code

Issue ticket number and link

AB#[10890]

Checklist - Manual tasks

  • Examples are executing successfully
  • Devcontainer can be opened successfully
  • Devcontainer can be opened successfully behind a corporate proxy
  • Devcontainer can be re-built successfully

…se status code

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
@emsameen emsameen self-requested a review August 17, 2022 13:11
Copy link
Member

@emsameen emsameen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to check the CI workflow before merge.

Thanks!

dennismeister93 and others added 3 commits August 17, 2022 17:14
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
* fix: fix GitHub workflow

- Trigger the notice file update only from the Github push to main branch event and not from the PR anymore.

* Fix review findings
@emsameen emsameen merged commit fd51727 into eclipse-velocitas:main Aug 29, 2022
@emsameen emsameen deleted the feature/10890-verify-implementation-of-wait-for-sidecar branch September 26, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants