Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11026] Fix GitHub workflow #15

Merged
merged 2 commits into from
Aug 26, 2022
Merged

[11026] Fix GitHub workflow #15

merged 2 commits into from
Aug 26, 2022

Conversation

emsameen
Copy link
Member

Describe your changes

  • Split the license workflow to multiple stages, PullRequest and Merge
  • Trigger the notice file update only from the Github push to main branch event and not from the PR anymore.

Issue ticket number and link

  • AB#11026

Checklist - Manual tasks

  • Examples are executing successfully
  • Created/updated unit tests. Code Coverage percentage on new code shall be >= 80%.
  • Created/updated integration tests.
  • Devcontainer can be opened successfully
  • Devcontainer can be opened successfully behind a corporate proxy
  • Devcontainer can be re-built successfully
  • Extended the documentation (e.g. README.md, CONTRIBUTING.md, Velocitas)

- Trigger the notice file update only from the Github push to main branch event and not from the PR anymore.
@emsameen emsameen requested a review from BjoernAtBosch August 26, 2022 09:29
@emsameen emsameen merged commit 593dd06 into main Aug 26, 2022
@emsameen emsameen deleted the 11026-fix_github_workflow branch August 26, 2022 09:39
dennismeister93 pushed a commit to SoftwareDefinedVehicle/vehicle-app-python-sdk that referenced this pull request Aug 26, 2022
* fix: fix GitHub workflow

- Trigger the notice file update only from the Github push to main branch event and not from the PR anymore.

* Fix review findings
emsameen added a commit that referenced this pull request Aug 29, 2022
#12)

* [10890] Verify implementation of wait_for_sidecar() checks for response status code

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>

* [10890] Fix linting

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>

* [11026] Fix GitHub workflow (#15)

* fix: fix GitHub workflow

- Trigger the notice file update only from the Github push to main branch event and not from the PR anymore.

* Fix review findings

* fix: remove head_refs from all readonly workflows (#17)

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
Co-authored-by: Ebrahim.A <ebrahim.ameen@bosch.com>
dennismeister93 pushed a commit to SoftwareDefinedVehicle/vehicle-app-python-sdk that referenced this pull request Aug 29, 2022
* fix: fix GitHub workflow

- Trigger the notice file update only from the Github push to main branch event and not from the PR anymore.

* Fix review findings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants