Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/10868 extract seatadjuster app to sdk #18

Conversation

dennismeister93
Copy link
Contributor

Description

Remove SeatAdjuster App from template and extract to SDK example folder
Adjust other examples to the same structure

Azure DevOps PBI/Task reference

AB#[10868]

Checklist

  • Vehicle App can be started with dapr run and is connecting to vehicle data broker

  • Vehicle App can process MQTT messages and call the seat service

  • Vehicle App can be deployed to local K3D and is running

  • Created/updated tests, if necessary. Code Coverage percentage on new code shall be >= 70%.

  • Extended the documentation in Velocitas repo

  • Extended the documentation in README.md

  • Devcontainer can be opened successfully

  • Devcontainer can be opened successfully behind a corporate proxy

  • Devcontainer can be re-built successfully

  • Release workflow is passing

dennismeister93 and others added 10 commits August 17, 2022 13:14
…se status code

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
* fix: fix GitHub workflow

- Trigger the notice file update only from the Github push to main branch event and not from the PR anymore.

* Fix review findings
…se status code

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
.github/workflows/check-licenses.yml Outdated Show resolved Hide resolved
examples/array-datatype/AppManifest.json Outdated Show resolved Hide resolved
examples/array-datatype/requirements-links.txt Outdated Show resolved Hide resolved
sdv/dapr/client.py Outdated Show resolved Hide resolved
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
@emsameen emsameen self-requested a review September 5, 2022 06:52
Copy link
Member

@emsameen emsameen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emsameen emsameen merged commit 4799a38 into eclipse-velocitas:main Sep 5, 2022
@emsameen emsameen deleted the feature/10868-extract-seatadjuster-app-to-sdk branch September 5, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants