build(publication): modifying workflows to publish snapshot packages #27
Conversation
|
@fuzzypixelz @JEnoch Could you please review this? :) |
|
By the way, 0.11.0-rc as next release version is not appropriate anymore or is it? |
|
This PR is related to #28 |
| @@ -79,3 +79,26 @@ jobs: | |||
| steps: | |||
| - name: Check whether all jobs pass | |||
| run: echo '${{ toJson(needs) }}' | jq -e 'all(.result == "success")' | |||
|
|
|||
| # Publish snapshot packages. These jobs will only be triggered when the CI is executed on main. | |||
There was a problem hiding this comment.
How much slower will the CI be because of this?
There was a problem hiding this comment.
Publications tend to take around 10 minutes.
There was a problem hiding this comment.
So that almost doubles it, making it ~20mins. I don't see it as particularly problematic. But we can always do it later on a nightly basis if it turns out to be too long.
There was a problem hiding this comment.
So far the cron job is set to be run at 6am, I think it's ok, if not we can change it later as you say.
.github/workflows/ci.yml
Outdated
| contents: read | ||
| packages: write | ||
| with: | ||
| version: 0.11.0-rc-SNAPSHOT |
There was a problem hiding this comment.
While this is technically valid semver, it is quite confusing (i.e. being a snapshot of a release candidate). I suggest going with 0.11.0-SNAPSHOT in this case, as it means roughly the same thing as 0.11.0-dev.
There was a problem hiding this comment.
Starting from the next release, we will drop the -rc pre-release identifier so we should be doing major.minor.patch-SNAPSHOT anyway.
The next release is |
|
I have changed quite a bit the logic of this PR, you may want to take a new look into it :) |
LGTM. Perhaps it's time to bump other repos to |
This PR modifies the Github workflows in order to trigger the publication of snapshot packages for both JVM and Android when the CI is run an is successful on main. This way changes and fixes during the development phase are accessible to users before a new release performed.