Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed JobEngineService error messages bundle configuration #3239

Merged

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Feb 12, 2021

This PR fixes the configuration for the Error Messages Bundle for Job Engine Service which is not mapped.

Related Issue
None

Description of the solution adopted
Just added the correct mapping.

Screenshots
None

Any side note on the changes made
None

Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
@Coduz Coduz added the Bug This is a bug or an unexpected behaviour. Fix it! label Feb 12, 2021
@Coduz Coduz requested a review from lorthirk February 12, 2021 17:56
@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #3239 (157e27a) into develop (5c6e49f) will decrease coverage by 15.65%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##             develop    #3239       +/-   ##
==============================================
- Coverage      59.41%   43.75%   -15.66%     
+ Complexity      3003     2426      -577     
==============================================
  Files           1273     1273               
  Lines          26991    26992        +1     
  Branches        2339     2339               
==============================================
- Hits           16036    11810     -4226     
- Misses         10057    14264     +4207     
- Partials         898      918       +20     
Impacted Files Coverage Δ Complexity Δ
...ob/engine/jbatch/exception/JobEngineException.java 28.57% <0.00%> (-38.10%) 1.00 <0.00> (-1.00)
...ua/job/engine/jbatch/setting/JobEngineSetting.java 100.00% <ø> (ø) 3.00 <0.00> (ø)
...rc/main/java/org/eclipse/kapua/KapuaException.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...c/main/java/org/eclipse/kapua/KapuaErrorCodes.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...in/java/org/eclipse/kapua/broker/BrokerDomain.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...ain/java/org/eclipse/kapua/event/ServiceEvent.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...n/java/org/eclipse/kapua/broker/BrokerDomains.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...va/org/eclipse/kapua/commons/util/SystemUtils.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...n/java/org/eclipse/kapua/model/domain/Actions.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
.../java/org/eclipse/kapua/ExceptionMessageUtils.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
... and 371 more

@lorthirk
Copy link

This will have an impact on #3238. How do we want to proceed?

@Coduz Coduz merged commit 7167323 into eclipse:develop Feb 16, 2021
@Coduz Coduz deleted the fix-jobEngineServiceMessageBundleConfig branch February 16, 2021 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants