-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schedule Trigger update feature #3240
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3240 +/- ##
=============================================
- Coverage 59.36% 58.97% -0.40%
- Complexity 3014 3028 +14
=============================================
Files 1273 1289 +16
Lines 27038 27239 +201
Branches 2346 2365 +19
=============================================
+ Hits 16052 16065 +13
- Misses 10089 10273 +184
- Partials 897 901 +4
|
lorthirk
approved these changes
Feb 16, 2021
Coduz
force-pushed
the
feature-triggerUpdate
branch
from
February 16, 2021 13:49
4a317b0
to
b199bb4
Compare
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Coduz
force-pushed
the
feature-triggerUpdate
branch
from
February 17, 2021 10:55
b199bb4
to
443b379
Compare
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Coduz
force-pushed
the
feature-triggerUpdate
branch
from
February 17, 2021 15:22
b932125
to
6ff5d54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the capability to edit a schedule.
This PR also adds a registry of all Trigger triggering which was until now not tracked.
Related Issue
None
Description of the solution adopted
Improved the TriggerService.update method to handle also modifying Quartz data.
Improved the exception handling and moved exception to
-api
module.Added a service which tracks fired triggers.
Screenshots
None
Any side note on the changes made
A bit of javadoc review and fixing.
This PR also contains a commit which has been submitted in a separate PR #3239