Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule Trigger update feature #3240

Merged
merged 8 commits into from
Feb 18, 2021
Merged

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Feb 15, 2021

This PR adds the capability to edit a schedule.

This PR also adds a registry of all Trigger triggering which was until now not tracked.

Related Issue
None

Description of the solution adopted
Improved the TriggerService.update method to handle also modifying Quartz data.
Improved the exception handling and moved exception to -api module.
Added a service which tracks fired triggers.

Screenshots
None

Any side note on the changes made
A bit of javadoc review and fixing.
This PR also contains a commit which has been submitted in a separate PR #3239

@Coduz Coduz added the Enhancement This PR/Issue improves an part of Kapua label Feb 15, 2021
@Coduz Coduz requested a review from lorthirk February 15, 2021 14:53
@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #3240 (8876288) into develop (ffd9a30) will decrease coverage by 0.39%.
The diff coverage is 19.50%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3240      +/-   ##
=============================================
- Coverage      59.36%   58.97%   -0.40%     
- Complexity      3014     3028      +14     
=============================================
  Files           1273     1289      +16     
  Lines          27038    27239     +201     
  Branches        2346     2365      +19     
=============================================
+ Hits           16052    16065      +13     
- Misses         10089    10273     +184     
- Partials         897      901       +4     
Impacted Files Coverage Δ Complexity Δ
...org/eclipse/kapua/KapuaDuplicateNameException.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...ipse/kapua/service/scheduler/SchedulerDomains.java 33.33% <0.00%> (-16.67%) 1.00 <0.00> (ø)
...r/exception/TriggerInvalidSchedulingException.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...lipse/kapua/service/scheduler/trigger/Trigger.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...a/service/scheduler/trigger/TriggerAttributes.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../service/scheduler/trigger/TriggerXmlRegistry.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...cheduler/trigger/definition/TriggerDefinition.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...rigger/definition/TriggerDefinitionAttributes.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...igger/definition/TriggerDefinitionXmlRegistry.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../service/scheduler/trigger/fired/FiredTrigger.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
... and 58 more

@Coduz Coduz force-pushed the feature-triggerUpdate branch from 4a317b0 to b199bb4 Compare February 16, 2021 13:49
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
@Coduz Coduz force-pushed the feature-triggerUpdate branch from b199bb4 to 443b379 Compare February 17, 2021 10:55
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
@Coduz Coduz force-pushed the feature-triggerUpdate branch from b932125 to 6ff5d54 Compare February 17, 2021 15:22
@Coduz Coduz merged commit fc8eb91 into eclipse:develop Feb 18, 2021
@Coduz Coduz deleted the feature-triggerUpdate branch February 18, 2021 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This PR/Issue improves an part of Kapua
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants